From: Patrick Mochel <mochel@linux.intel.com>
To: "Randy.Dunlap" <rdunlap@xenotime.net>
Cc: linux-acpi@vger.kernel.org, len.brown@intel.com
Subject: Re: [PATCH] acpi: make message more descriptive/meaningful
Date: Tue, 7 Feb 2006 10:18:09 -0800 [thread overview]
Message-ID: <20060207181809.GA3692@linux.intel.com> (raw)
In-Reply-To: <20060206192910.66cb9c86.rdunlap@xenotime.net>
On Mon, Feb 06, 2006 at 07:29:10PM -0800, Randy.Dunlap wrote:
> Identify which device is not power-manageable to make
> the message more useful.
> --- linux-2615-rc6g4.orig/drivers/acpi/bus.c
> +++ linux-2615-rc6g4/drivers/acpi/bus.c
> @@ -198,7 +198,8 @@ int acpi_bus_set_power(acpi_handle handl
>
> if (!device->flags.power_manageable) {
> ACPI_DEBUG_PRINT((ACPI_DB_WARN,
> - "Device is not power manageable\n"));
> + "Device '%s' is not power manageable\n",
> + device->kobj.name));
This is good information, but does it have to come in such a scary message?
It appears that something is wrong with the device, when in fact, it just
doesn't support an optional capability.
Could we demote the message to e.g. ACPI_DB_INFO?
Thanks,
Patrick
next prev parent reply other threads:[~2006-02-07 18:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-07 3:29 [PATCH] acpi: make message more descriptive/meaningful Randy.Dunlap
2006-02-07 18:18 ` Patrick Mochel [this message]
2006-02-07 18:18 ` Randy.Dunlap
2006-02-09 18:30 ` Thomas Renninger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060207181809.GA3692@linux.intel.com \
--to=mochel@linux.intel.com \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox