* [RFC: 2.6 patch] drivers/acpi/utilities/utmisc.c: remove 3 unused global functions
@ 2006-02-20 22:36 Adrian Bunk
0 siblings, 0 replies; 2+ messages in thread
From: Adrian Bunk @ 2006-02-20 22:36 UTC (permalink / raw)
To: len.brown; +Cc: linux-acpi, linux-kernel
This patch removes the following four unused global functions from
drivers/acpi/utilities/utmisc.c:
- acpi_ut_strupr()
- acpi_ut_report_warning()
- acpi_ut_report_info()
Is this patch OK or is future usage planned or are they still used on
other operating systems?
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
drivers/acpi/utilities/utmisc.c | 44 --------------------------------
include/acpi/acutils.h | 6 ----
2 files changed, 50 deletions(-)
--- linux-2.6.16-rc1-mm5-full/include/acpi/acutils.h.old 2006-02-03 19:28:37.000000000 +0100
+++ linux-2.6.16-rc1-mm5-full/include/acpi/acutils.h 2006-02-03 19:29:42.000000000 +0100
@@ -279,10 +279,6 @@
void acpi_ut_report_error(char *module_name, u32 line_number);
-void acpi_ut_report_info(char *module_name, u32 line_number);
-
-void acpi_ut_report_warning(char *module_name, u32 line_number);
-
/* Error and message reporting interfaces */
void ACPI_INTERNAL_VAR_XFACE
@@ -454,8 +450,6 @@
void *target_object,
acpi_pkg_callback walk_callback, void *context);
-void acpi_ut_strupr(char *src_string);
-
void acpi_ut_print_string(char *string, u8 max_length);
u8 acpi_ut_valid_acpi_name(u32 name);
--- linux-2.6.16-rc1-mm5-full/drivers/acpi/utilities/utmisc.c.old 2006-02-03 19:28:53.000000000 +0100
+++ linux-2.6.16-rc1-mm5-full/drivers/acpi/utilities/utmisc.c 2006-02-03 19:30:04.000000000 +0100
@@ -217,39 +217,6 @@
/*******************************************************************************
*
- * FUNCTION: acpi_ut_strupr (strupr)
- *
- * PARAMETERS: src_string - The source string to convert
- *
- * RETURN: None
- *
- * DESCRIPTION: Convert string to uppercase
- *
- * NOTE: This is not a POSIX function, so it appears here, not in utclib.c
- *
- ******************************************************************************/
-
-void acpi_ut_strupr(char *src_string)
-{
- char *string;
-
- ACPI_FUNCTION_ENTRY();
-
- if (!src_string) {
- return;
- }
-
- /* Walk entire string, uppercasing the letters */
-
- for (string = src_string; *string; string++) {
- *string = (char)ACPI_TOUPPER(*string);
- }
-
- return;
-}
-
-/*******************************************************************************
- *
* FUNCTION: acpi_ut_print_string
*
* PARAMETERS: String - Null terminated ASCII string
@@ -922,14 +864,3 @@
acpi_os_printf("ACPI Error (%s-%04d): ", module_name, line_number);
}
-void acpi_ut_report_warning(char *module_name, u32 line_number)
-{
-
- acpi_os_printf("ACPI Warning (%s-%04d): ", module_name, line_number);
-}
-
-void acpi_ut_report_info(char *module_name, u32 line_number)
-{
-
- acpi_os_printf("ACPI (%s-%04d): ", module_name, line_number);
-}
^ permalink raw reply [flat|nested] 2+ messages in thread
* RE: [RFC: 2.6 patch] drivers/acpi/utilities/utmisc.c: remove 3 unused global functions
@ 2006-02-21 23:14 Moore, Robert
0 siblings, 0 replies; 2+ messages in thread
From: Moore, Robert @ 2006-02-21 23:14 UTC (permalink / raw)
To: Adrian Bunk, Brown, Len; +Cc: linux-acpi, linux-kernel
Acpi_ut_strupr is used by the iASL compiler. I am probably going to put
a conditional compile around it.
The two report functions are obsolete, but may still be used by some of
the drivers. They will be removed soon.
> -----Original Message-----
> From: linux-acpi-owner@vger.kernel.org [mailto:linux-acpi-
> owner@vger.kernel.org] On Behalf Of Adrian Bunk
> Sent: Monday, February 20, 2006 2:36 PM
> To: Brown, Len
> Cc: linux-acpi@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [RFC: 2.6 patch] drivers/acpi/utilities/utmisc.c: remove 3
unused
> global functions
>
> This patch removes the following four unused global functions from
> drivers/acpi/utilities/utmisc.c:
> - acpi_ut_strupr()
> - acpi_ut_report_warning()
> - acpi_ut_report_info()
>
> Is this patch OK or is future usage planned or are they still used on
> other operating systems?
>
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
>
> ---
>
> drivers/acpi/utilities/utmisc.c | 44
--------------------------------
> include/acpi/acutils.h | 6 ----
> 2 files changed, 50 deletions(-)
>
> --- linux-2.6.16-rc1-mm5-full/include/acpi/acutils.h.old
2006-02-03
> 19:28:37.000000000 +0100
> +++ linux-2.6.16-rc1-mm5-full/include/acpi/acutils.h 2006-02-03
> 19:29:42.000000000 +0100
> @@ -279,10 +279,6 @@
>
> void acpi_ut_report_error(char *module_name, u32 line_number);
>
> -void acpi_ut_report_info(char *module_name, u32 line_number);
> -
> -void acpi_ut_report_warning(char *module_name, u32 line_number);
> -
> /* Error and message reporting interfaces */
>
> void ACPI_INTERNAL_VAR_XFACE
> @@ -454,8 +450,6 @@
> void *target_object,
> acpi_pkg_callback walk_callback, void
*context);
>
> -void acpi_ut_strupr(char *src_string);
> -
> void acpi_ut_print_string(char *string, u8 max_length);
>
> u8 acpi_ut_valid_acpi_name(u32 name);
> --- linux-2.6.16-rc1-mm5-full/drivers/acpi/utilities/utmisc.c.old
2006-02-
> 03 19:28:53.000000000 +0100
> +++ linux-2.6.16-rc1-mm5-full/drivers/acpi/utilities/utmisc.c 2006-02-
> 03 19:30:04.000000000 +0100
> @@ -217,39 +217,6 @@
>
>
>
/***********************************************************************
**
> ******
> *
> - * FUNCTION: acpi_ut_strupr (strupr)
> - *
> - * PARAMETERS: src_string - The source string to convert
> - *
> - * RETURN: None
> - *
> - * DESCRIPTION: Convert string to uppercase
> - *
> - * NOTE: This is not a POSIX function, so it appears here, not in
> utclib.c
> - *
> -
>
************************************************************************
**
> ****/
> -
> -void acpi_ut_strupr(char *src_string)
> -{
> - char *string;
> -
> - ACPI_FUNCTION_ENTRY();
> -
> - if (!src_string) {
> - return;
> - }
> -
> - /* Walk entire string, uppercasing the letters */
> -
> - for (string = src_string; *string; string++) {
> - *string = (char)ACPI_TOUPPER(*string);
> - }
> -
> - return;
> -}
> -
> -
>
/***********************************************************************
**
> ******
> - *
> * FUNCTION: acpi_ut_print_string
> *
> * PARAMETERS: String - Null terminated ASCII string
> @@ -922,14 +864,3 @@
> acpi_os_printf("ACPI Error (%s-%04d): ", module_name,
line_number);
> }
>
> -void acpi_ut_report_warning(char *module_name, u32 line_number)
> -{
> -
> - acpi_os_printf("ACPI Warning (%s-%04d): ", module_name,
> line_number);
> -}
> -
> -void acpi_ut_report_info(char *module_name, u32 line_number)
> -{
> -
> - acpi_os_printf("ACPI (%s-%04d): ", module_name, line_number);
> -}
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-acpi"
in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-02-21 23:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-02-20 22:36 [RFC: 2.6 patch] drivers/acpi/utilities/utmisc.c: remove 3 unused global functions Adrian Bunk
-- strict thread matches above, loose matches on Subject: below --
2006-02-21 23:14 Moore, Robert
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).