From: Andi Kleen <ak@muc.de>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: akpm@osdl.org, y-goto@jp.fujitsu.com, linux-acpi@vger.kernel.org,
tony.luck@intel.com
Subject: Re: CONFIG_ACPI_HOTPLUG_MEMORY=m with x86_64 devel tree II
Date: 30 Mar 2006 16:18:11 +0200
Date: Thu, 30 Mar 2006 16:18:11 +0200 [thread overview]
Message-ID: <20060330141811.GA84501@muc.de> (raw)
In-Reply-To: <20060330225459.c2c53dbe.kamezawa.hiroyu@jp.fujitsu.com>
On Thu, Mar 30, 2006 at 10:54:59PM +0900, KAMEZAWA Hiroyuki wrote:
> On 30 Mar 2006 15:41:33 +0200
> Andi Kleen <ak@muc.de> wrote:
>
> >
> > Hi,
> >
> > I started to implement your suggestion now.
> >
> > But one problem I noticed and I don't see how the current sparsemem code
> > handles correctly is that it makes no attempt to handle hotadd
> > areas that cross zone boundaries. Is there code somewhere that rejects
> > them?
> >
>
> add_memory() selects a zone which pages are added, before adding memory regardless
> of its address. Now this is hard-coded.
>
> ia64 adds memory to NORMAL.
> i386 adds memory to HIGHMEM.
> x86_64 adds memory to NORMAL.
Yes but what stops ACPI from trying to add memory that crosses
a zone? (e.g. from 2GB to 6GB)
>
> if x86_64 people wants to add memory to DMA32 or some other zone, please add code.
I added a check for it in the reserve hotadd code now.
-Andi
next prev parent reply other threads:[~2006-03-30 14:18 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-22 6:23 CONFIG_ACPI_HOTPLUG_MEMORY=m with x86_64 devel tree Andrew Morton
2006-03-22 10:56 ` Yasunori Goto
2006-03-22 11:02 ` Andrew Morton
2006-03-22 11:32 ` KAMEZAWA Hiroyuki
2006-03-22 19:21 ` Andi Kleen
2006-03-22 23:27 ` KAMEZAWA Hiroyuki
2006-03-23 0:07 ` Andi Kleen
2006-03-23 0:36 ` KAMEZAWA Hiroyuki
2006-03-23 2:43 ` Andi Kleen
2006-03-23 2:55 ` KAMEZAWA Hiroyuki
2006-03-23 3:22 ` KAMEZAWA Hiroyuki
2006-03-23 15:37 ` Andi Kleen
2006-03-23 3:59 ` KAMEZAWA Hiroyuki
2006-03-30 13:41 ` CONFIG_ACPI_HOTPLUG_MEMORY=m with x86_64 devel tree II Andi Kleen
2006-03-30 13:54 ` KAMEZAWA Hiroyuki
2006-03-30 14:18 ` Andi Kleen [this message]
2006-03-30 14:25 ` KAMEZAWA Hiroyuki
2006-03-30 14:31 ` Andi Kleen
2006-03-22 17:13 ` CONFIG_ACPI_HOTPLUG_MEMORY=m with x86_64 devel tree Andi Kleen
2006-03-22 19:23 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060330141811.GA84501@muc.de \
--to=ak@muc.de \
--cc=akpm@osdl.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-acpi@vger.kernel.org \
--cc=tony.luck@intel.com \
--cc=y-goto@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox