* 2.6.17-rc1-mm1: why did acpi_ns_build_external_path() become global? [not found] <20060404014504.564bf45a.akpm@osdl.org> @ 2006-04-04 16:29 ` Adrian Bunk 2006-04-07 12:27 ` 2.6.17-rc1-mm1: drivers/acpi/numa.c compile error Adrian Bunk 1 sibling, 0 replies; 5+ messages in thread From: Adrian Bunk @ 2006-04-04 16:29 UTC (permalink / raw) To: Andrew Morton, len.brown; +Cc: linux-kernel, linux-acpi On Tue, Apr 04, 2006 at 01:45:04AM -0700, Andrew Morton wrote: >... > Changes since 2.6.16-mm2: > > git-acpi.patch >... > git trees. >... acpi_ns_build_external_path() became global but isn't used outside the file it's defined in. Was this accidental or is a usage pending? cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed ^ permalink raw reply [flat|nested] 5+ messages in thread
* 2.6.17-rc1-mm1: drivers/acpi/numa.c compile error [not found] <20060404014504.564bf45a.akpm@osdl.org> 2006-04-04 16:29 ` 2.6.17-rc1-mm1: why did acpi_ns_build_external_path() become global? Adrian Bunk @ 2006-04-07 12:27 ` Adrian Bunk 2006-04-07 20:59 ` Andrew Morton 1 sibling, 1 reply; 5+ messages in thread From: Adrian Bunk @ 2006-04-07 12:27 UTC (permalink / raw) To: Andrew Morton, len.brown; +Cc: linux-kernel, linux-acpi I'm getting the following compile error with CONFIG_ACPI_NUMA=y: <-- snip --> ... CC drivers/acpi/numa.o drivers/acpi/numa.c: In function 'acpi_numa_init': drivers/acpi/numa.c:231: error: 'NR_NODE_MEMBLKS' undeclared (first use in this function) drivers/acpi/numa.c:231: error: (Each undeclared identifier is reported only once drivers/acpi/numa.c:231: error: for each function it appears in.) make[2]: *** [drivers/acpi/numa.o] Error 1 <-- snip --> cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: 2.6.17-rc1-mm1: drivers/acpi/numa.c compile error 2006-04-07 12:27 ` 2.6.17-rc1-mm1: drivers/acpi/numa.c compile error Adrian Bunk @ 2006-04-07 20:59 ` Andrew Morton 2006-04-09 15:44 ` Adrian Bunk 0 siblings, 1 reply; 5+ messages in thread From: Andrew Morton @ 2006-04-07 20:59 UTC (permalink / raw) To: Adrian Bunk; +Cc: len.brown, linux-kernel, linux-acpi, Yasunori Goto Adrian Bunk <bunk@stusta.de> wrote: > > I'm getting the following compile error with CONFIG_ACPI_NUMA=y: > > <-- snip --> > > ... > CC drivers/acpi/numa.o > drivers/acpi/numa.c: In function 'acpi_numa_init': > drivers/acpi/numa.c:231: error: 'NR_NODE_MEMBLKS' undeclared (first use in this function) I'm not quite sure how we managed that, but I guess unify-pxm_to_node-and-node_to_pxm.patch triggered it? ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: 2.6.17-rc1-mm1: drivers/acpi/numa.c compile error 2006-04-07 20:59 ` Andrew Morton @ 2006-04-09 15:44 ` Adrian Bunk 2006-04-09 15:57 ` Randy.Dunlap 0 siblings, 1 reply; 5+ messages in thread From: Adrian Bunk @ 2006-04-09 15:44 UTC (permalink / raw) To: Andrew Morton Cc: len.brown, linux-kernel, linux-acpi, Yasunori Goto, tony.luck, Andi Kleen, Dave Hansen On Fri, Apr 07, 2006 at 01:59:37PM -0700, Andrew Morton wrote: > Adrian Bunk <bunk@stusta.de> wrote: > > > > I'm getting the following compile error with CONFIG_ACPI_NUMA=y: > > > > <-- snip --> > > > > ... > > CC drivers/acpi/numa.o > > drivers/acpi/numa.c: In function 'acpi_numa_init': > > drivers/acpi/numa.c:231: error: 'NR_NODE_MEMBLKS' undeclared (first use in this function) > > I'm not quite sure how we managed that, but I guess > unify-pxm_to_node-and-node_to_pxm.patch triggered it? Yes, obviously (I got this error on i386): config ACPI_NUMA bool "NUMA support" depends on NUMA - depends on (IA64 || X86_64) + depends on (X86_32 || IA64 || X86_64) default y if IA64_GENERIC || IA64_SGI_SN2 cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: 2.6.17-rc1-mm1: drivers/acpi/numa.c compile error 2006-04-09 15:44 ` Adrian Bunk @ 2006-04-09 15:57 ` Randy.Dunlap 0 siblings, 0 replies; 5+ messages in thread From: Randy.Dunlap @ 2006-04-09 15:57 UTC (permalink / raw) To: Adrian Bunk Cc: akpm, len.brown, linux-kernel, linux-acpi, y-goto, tony.luck, ak, haveblue On Sun, 9 Apr 2006 17:44:46 +0200 Adrian Bunk wrote: > On Fri, Apr 07, 2006 at 01:59:37PM -0700, Andrew Morton wrote: > > Adrian Bunk <bunk@stusta.de> wrote: > > > > > > I'm getting the following compile error with CONFIG_ACPI_NUMA=y: > > > > > > <-- snip --> > > > > > > ... > > > CC drivers/acpi/numa.o > > > drivers/acpi/numa.c: In function 'acpi_numa_init': > > > drivers/acpi/numa.c:231: error: 'NR_NODE_MEMBLKS' undeclared (first use in this function) > > > > I'm not quite sure how we managed that, but I guess > > unify-pxm_to_node-and-node_to_pxm.patch triggered it? > > Yes, obviously (I got this error on i386): > > config ACPI_NUMA > bool "NUMA support" > depends on NUMA > - depends on (IA64 || X86_64) > + depends on (X86_32 || IA64 || X86_64) > default y if IA64_GENERIC || IA64_SGI_SN2 The new/fixed line should just be depends on X86 || IA64 since X86_32 and X86_64 both set X86. --- ~Randy ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2006-04-09 15:54 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20060404014504.564bf45a.akpm@osdl.org>
2006-04-04 16:29 ` 2.6.17-rc1-mm1: why did acpi_ns_build_external_path() become global? Adrian Bunk
2006-04-07 12:27 ` 2.6.17-rc1-mm1: drivers/acpi/numa.c compile error Adrian Bunk
2006-04-07 20:59 ` Andrew Morton
2006-04-09 15:44 ` Adrian Bunk
2006-04-09 15:57 ` Randy.Dunlap
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox