From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Subject: Re: [RFC] [PATCH] Make ACPI button driver an input device Date: Thu, 20 Apr 2006 22:10:06 +0000 Message-ID: <20060420221006.GG2352@ucw.cz> References: <554C5F4C5BA7384EB2B412FD46A3BAD1332980@pdsmsx411.ccr.corp.intel.com> <20060420073713.GA25735@srcf.ucam.org> <4447AA59.8010300@linux.intel.com> <20060420153848.GA29726@srcf.ucam.org> <4447AF4D.7030507@linux.intel.com> <20060420161546.GB30021@srcf.ucam.org> <4447B692.3000704@linux.intel.com> <20060420163222.GA30197@srcf.ucam.org> <4447B850.7090108@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from gprs189-60.eurotel.cz ([160.218.189.60]:60937 "EHLO spitz.ucw.cz") by vger.kernel.org with ESMTP id S1751079AbWDVT2B (ORCPT ); Sat, 22 Apr 2006 15:28:01 -0400 Content-Disposition: inline In-Reply-To: <4447B850.7090108@linux.intel.com> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Alexey Starikovskiy Cc: Matthew Garrett , "Yu, Luming" , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org On Thu 20-04-06 20:35:28, Alexey Starikovskiy wrote: > Matthew Garrett wrote: > >On Thu, Apr 20, 2006 at 08:28:02PM +0400, Alexey > >Starikovskiy wrote: > > > >>I don't quite understand your point... You want all > >>buttons/switches in a computer to send events to input > >>layer, regardless if this make sense or not, just to be > >>consistent? May be you should go other way around and > >>if keyboard has some strange key, send it on its > >>strange way? > > > >There's a reason that KEY_POWER and KEY_SLEEP are > >already present in /usr/include/linux/input.h. It makes > >sense to expose keys that are on my keyboard in the same > >way as other keys on my keyboard. Just think of the ACPI > >events interface as a bus that a small keyboard with not > >many keys sits on. > > > >>From the userspace point of view, it's *far* easier to > >>deal with this > >stuff if the keys generate keycodes. > Lid is a _switch_ with state, how many keys on keyboard > have same behavior? Do you want to introduce special case > just for that? It is already there. Handhelds have lid switches controlled by input. Old capslock keys (around XT era) actually worked like that, too. (And input was actually _designed_ to handle them). Pavel -- Thanks, Sharp!