From: Bjorn Helgaas <bjorn.helgaas@hp.com>
To: trenn@suse.de
Cc: linux-acpi@vger.kernel.org, "Brown, Len" <len.brown@intel.com>
Subject: Re: Exit ACPI drivers immediately if acpi is disabled
Date: Mon, 24 Apr 2006 08:59:08 -0600 [thread overview]
Message-ID: <200604240859.09012.bjorn.helgaas@hp.com> (raw)
In-Reply-To: <1145875957.3797.15.camel@queen.suse.de>
On Monday 24 April 2006 04:52, Thomas Renninger wrote:
> Rethinking about this: driver_registered is a bit too general variable?
>
> Is this OK, now?
It's static, so I don't care either way.
The powernow/speedstep/acpi code sharing seems a little strange, but
I don't know anything about it. And you're not changing that part
of things anyway.
> @@ -943,12 +947,13 @@ static void __exit acpi_processor_exit(v
>
> acpi_thermal_cpufreq_exit();
>
> + if (processor_driver_registered){
> acpi_processor_uninstall_hotplug_notify();
>
> acpi_bus_unregister_driver(&acpi_processor_driver);
>
> remove_proc_entry(ACPI_PROCESSOR_CLASS, acpi_root_dir);
> -
> + }
Shouldn't the remove_proc_entry() be outside the "if (processor_driver_registered)"
block? The directory was created unconditionally, before the
acpi_bus_register_driver() call.
next prev parent reply other threads:[~2006-04-24 14:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-21 10:43 Exit ACPI drivers immediately if acpi is disabled Thomas Renninger
2006-04-21 15:18 ` Bjorn Helgaas
2006-04-21 16:53 ` Thomas Renninger
2006-04-21 16:58 ` Dominik Brodowski
2006-04-21 17:18 ` Thomas Renninger
2006-04-24 10:52 ` Thomas Renninger
2006-04-24 14:59 ` Bjorn Helgaas [this message]
2006-04-24 15:57 ` Thomas Renninger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200604240859.09012.bjorn.helgaas@hp.com \
--to=bjorn.helgaas@hp.com \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=trenn@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox