From: Andi Kleen <ak@muc.de>
To: akpm@osdl.org
Cc: len.brown@intel.com, linux-acpi@vger.kernel.org,
ACurrid@nvidia.com, luming.yu@intel.com
Subject: Re: [patch 12/13] Fix HPET operation on 64-bit NVIDIA platforms
Date: 2 Jun 2006 05:47:51 +0200
Date: Fri, 2 Jun 2006 05:47:51 +0200 [thread overview]
Message-ID: <20060602034751.GC62654@muc.de> (raw)
In-Reply-To: <200606020314.k523EXuI028340@shell0.pdx.osdl.net>
> #ifdef CONFIG_ACPI
> - /* All timer overrides on Nvidia
> - seem to be wrong. Skip them. */
> - acpi_skip_timer_override = 1;
> - printk(KERN_INFO
> - "Nvidia board detected. Ignoring ACPI timer override.\n");
> + /*
> + * All timer overrides on Nvidia are
> + * wrong unless HPET is enabled.
> + */
> + nvidia_hpet_detected = 0;
> + acpi_table_parse(ACPI_HPET,
> + nvidia_hpet_check);
I'm not sure it's safe to call acpi_table_parse() when the user passed acpi=off
Better would be probably to set a flag in the HPET callback in arch/i386/kernel/acpi/boot.c
-Andi
next prev parent reply other threads:[~2006-06-02 3:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-02 3:18 [patch 12/13] Fix HPET operation on 64-bit NVIDIA platforms akpm
2006-06-02 3:47 ` Andi Kleen [this message]
2006-06-06 15:06 ` Sergio Monteiro Basto
-- strict thread matches above, loose matches on Subject: below --
2006-06-02 18:22 Andy Currid
2006-06-02 20:37 ` Andi Kleen
2006-06-06 15:11 Andy Currid
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060602034751.GC62654@muc.de \
--to=ak@muc.de \
--cc=ACurrid@nvidia.com \
--cc=akpm@osdl.org \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=luming.yu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox