public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: linux-kernel@vger.kernel.org, len.brown@intel.com,
	linux-acpi@vger.kernel.org
Subject: Re: [Ubuntu PATCH] acpi: Add IBM R60E laptop to proc-idle blacklist
Date: Mon, 19 Jun 2006 20:33:33 -0700	[thread overview]
Message-ID: <20060619203333.5e897ead.akpm@osdl.org> (raw)
In-Reply-To: <4491BC6B.5000704@oracle.com>

On Thu, 15 Jun 2006 13:00:43 -0700
Randy Dunlap <randy.dunlap@oracle.com> wrote:

> [UBUNTU:acpi] Add IBM R60E laptop to proc-idle blacklist.
> 
> Reference: https://launchpad.net/distros/ubuntu/+source/linux-source-2.6.15/+bug/38228
> http://www.kernel.org/git/?p=linux/kernel/git/bcollins/ubuntu-dapper.git;a=commit;h=ce5e62bc55056049d192c422b6032f6a406e0ba2
> 
> Signed-off-by: Ben Collins <bcollins@ubuntu.com>
> ---
>  drivers/acpi/processor_idle.c |    3 +++
>  1 files changed, 3 insertions(+)
> 
> --- linux-2617-rc6g7.orig/drivers/acpi/processor_idle.c
> +++ linux-2617-rc6g7/drivers/acpi/processor_idle.c
> @@ -142,6 +142,9 @@ static struct dmi_system_id __cpuinitdat
>  	{ set_max_cstate, "IBM ThinkPad R40e", {
>  	  DMI_MATCH(DMI_BIOS_VENDOR,"IBM"),
>  	  DMI_MATCH(DMI_BIOS_VERSION,"1SET68WW") }, (void*)1},
> +	{ set_max_cstate, "IBM ThinkPad R40e", {
> +	  DMI_MATCH(DMI_BIOS_VENDOR, "IBM"),
> +	  DMI_MATCH(DMI_BIOS_VERSION, "1SET70WW") }, (void*)1},
>  	{ set_max_cstate, "Medion 41700", {
>  	  DMI_MATCH(DMI_BIOS_VENDOR,"Phoenix Technologies LTD"),
>  	  DMI_MATCH(DMI_BIOS_VERSION,"R01-A1J")}, (void *)1},
> 

It seems that every R40e in the world is in that table.

Can/should we wildcard it?  From my reading of dmi_check_system(), we can use
"" in place of the "1SET..." string and it'll dtrt?

       reply	other threads:[~2006-06-20  3:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <4491BC6B.5000704@oracle.com>
2006-06-20  3:33 ` Andrew Morton [this message]
2006-06-20  3:51   ` [Ubuntu PATCH] acpi: Add IBM R60E laptop to proc-idle blacklist Ben Pfaff
2006-06-20  5:16     ` Randy.Dunlap
2006-06-20  9:30     ` Matthew Garrett
2006-06-20  9:30   ` Matthew Garrett
2006-06-20 19:56     ` Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060619203333.5e897ead.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=len.brown@intel.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=randy.dunlap@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox