From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rajesh Shah Subject: Re: [PATCH 7/25] msi: Refactor the msi_ops. Date: Tue, 20 Jun 2006 18:18:19 -0700 Message-ID: <20060620181819.D10402@unix-os.sc.intel.com> References: <11508425183073-git-send-email-ebiederm@xmission.com> <11508425191381-git-send-email-ebiederm@xmission.com> <11508425192220-git-send-email-ebiederm@xmission.com> <11508425191063-git-send-email-ebiederm@xmission.com> <1150842520235-git-send-email-ebiederm@xmission.com> <11508425201406-git-send-email-ebiederm@xmission.com> <1150842520775-git-send-email-ebiederm@xmission.com> Reply-To: Rajesh Shah Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mga06.intel.com ([134.134.136.21]:23481 "EHLO orsmga101.jf.intel.com") by vger.kernel.org with ESMTP id S1750768AbWFUBXs (ORCPT ); Tue, 20 Jun 2006 21:23:48 -0400 Content-Disposition: inline In-Reply-To: <1150842520775-git-send-email-ebiederm@xmission.com>; from ebiederm@xmission.com on Tue, Jun 20, 2006 at 04:28:20PM -0600 Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: "Eric W. Biederman" Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-pci@atrey.karlin.mff.cuni.cz, discuss@x86-64.org, Ingo Molnar , Thomas Gleixner , Andi Kleen , Natalie Protasevich , Len Brown , Kimball Murray , Brice Goglin , Greg Lindahl , Dave Olson , Jeff Garzik , Greg KH , Grant Grundler , "bibo,mao" , Rajesh Shah , Mark Maule , Jesper Juhl , Shaohua Li , Matthew Wilcox , "Michael S. Tsirkin" , Ashok Raj , Randy Dunlap On Tue, Jun 20, 2006 at 04:28:20PM -0600, Eric W. Biederman wrote: > drivers/pci/msi-altix.c | 49 +++++++++++++++++++------------------ > drivers/pci/msi-apic.c | 36 ++++++++++++++------------- > drivers/pci/msi.c | 22 ++++++++--------- > drivers/pci/msi.h | 62 ----------------------------------------------- > include/linux/pci.h | 62 +++++++++++++++++++++++++++++++++++++++++++++++ I think the platform/arch specific code here should move to arch/. For example, msi-altix can go to arch/ia64/sn/pci, msi-apic.c can go to arch/i386/pci (and can be shared by x86_64)... Rajesh