From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adrian Bunk Subject: [-mm patch] drivers/acpi/scan.c: make acpi_bus_type static Date: Wed, 21 Jun 2006 23:57:17 +0200 Message-ID: <20060621215717.GJ9111@stusta.de> References: <20060621034857.35cfe36f.akpm@osdl.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mailout.stusta.mhn.de ([141.84.69.5]:46346 "HELO mailout.stusta.mhn.de") by vger.kernel.org with SMTP id S1030319AbWFUV5S (ORCPT ); Wed, 21 Jun 2006 17:57:18 -0400 Content-Disposition: inline In-Reply-To: <20060621034857.35cfe36f.akpm@osdl.org> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Andrew Morton , len.brown@intel.com Cc: linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org On Wed, Jun 21, 2006 at 03:48:57AM -0700, Andrew Morton wrote: >... > Changes since 2.6.17-rc6-mm2: >... > git-acpi.patch >... > git trees >... This patch makes the needlessly global acpi_bus_type static. I'd also suggest to rename this struct, since although it's named acpi_bus_type, it's of type "struct bus_type", not "struct acpi_bus_type" as defined in include/acpi/acpi_bus.h . Signed-off-by: Adrian Bunk --- linux-2.6.17-mm1-full/drivers/acpi/scan.c.old 2006-06-21 22:35:30.000000000 +0200 +++ linux-2.6.17-mm1-full/drivers/acpi/scan.c 2006-06-21 22:35:40.000000000 +0200 @@ -1450,7 +1450,7 @@ } -struct bus_type acpi_bus_type = { +static struct bus_type acpi_bus_type = { .name = "acpi", .suspend = acpi_device_suspend, .resume = acpi_device_resume,