From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ingo Molnar Subject: Re: [patch] ACPI: reduce code size, clean up, fix validator message Date: Sun, 25 Jun 2006 21:54:40 +0200 Message-ID: <20060625195440.GC11494@elte.hu> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mx3.mail.elte.hu ([157.181.1.138]:30931 "EHLO mx3.mail.elte.hu") by vger.kernel.org with ESMTP id S965512AbWFYT7e (ORCPT ); Sun, 25 Jun 2006 15:59:34 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: "Brown, Len" Cc: Andrew Morton , michal.k.k.piotrowski@gmail.com, arjan@linux.intel.com, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, "Moore, Robert" , Arjan van de Ven * Brown, Len wrote: > Ingo, > Thanks for the quick reply. > > An Andrew's advice a while back, Bob already got rid > of the allocate part -- it just isn't upstream yet. > > Re: changing ACPICA code (sub-directories of drivers/acpi/) like this: > > >- flags = acpi_os_acquire_lock(acpi_gbl_gpe_lock); > >+ spin_lock_irqsave(&acpi_gbl_gpe_lock, flags); > > I can't do that without either > 1. diverging between Linux and ACPICA > or > 2. getting a license back from you to Intel such that Intel can > re-distrubute such a change under the Intel license on the file and > inventing spin_lock_irqsave() on about 9 other operating systems. btw., regarding #2 i hereby put my patch (which i wrote in my free time) into the public domain - feel free to reuse it in any way, shape or form, under any license. (but it's trivial enough so i guess the only copyrightable element is my changelog entry anyway ;) > If this code were performance or size critical, I would still delete > acpi_os_acquire_lock from osl.c, but would inline it in aclinux.h. well its in the kernel so it's size critical by definition. But it's certainly not a highprio thing. Ingo