Re: [patch 11/18] pnpacpi: reject ACPI_PRODUCER resources

Shaohua Li
2006-06-27T07:32:11Z

On Tue, 2006-06-27 at 15:37 +0800, Adam Belay wrote:
> On Tue, Jun 27, 2006 at 12:03:24AM -0700, Andrew Morton wrote:
> > On Tue, 27 Jun 2006 02:30:13 -0400
> > "Brown, Len" <len.brown@intel.com> wrote:
> >
> > > NAK, per Shaohua's comments in the bug report.
> > >
> > > ...
> > >
> > > >
> > > >This patch fixes bug 6292
> > > >(http://bugzilla.kernel.org/show_bug.cgi?id=6292).
> >
> > Sigh. Uwe is available to test patches, should any happen to get
> written.
>
> I think we want something like this one...
>
> http://bugzilla.kernel.org/attachment.cgi?id=7931&action=view
Exactly.

> Regarding the bug report: Shaohua, if I understand correctly, we used
> to
> blacklist PCI root buses in the old implementation but it was changed
> here:
>
> http://www.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=c4bb6f5ad968540d7f9619565bacd18d7419b85f
Thanks and sorry I didn't find the issue before. We'd better blacklist
root bridge. I saw at lest one BIOS (IA64 box) didn't assign correct
producer/consumer flag to root bridge resources. Blacklist it is much
safer.

Thanks,
Shaohua