Re: [patch 11/18] pnpacpi: reject ACPI_PRODUCER resources

Bjorn Helgaas
2006-06-27T16:04:26Z

On Tuesday 27 June 2006 06:02, castet.matthieu@free.fr wrote:
> Selon Shaohua Li <shaohua.li@intel.com>:
> http://www.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=c4bb6f5ad968540d7f9619565bacd18d7419b85f
> > Thanks and sorry I didn't find the issue before. We'd better blacklist
> > root bridge. I saw at lest one BIOS (IA64 box) didn't assign correct
> > producer/consumer flag to root bridge resources. Blacklist it is much
> > safer.

If there's a specific broken BIOS, I'd prefer a quirk-type
mechanism to work around it.

> Is only PNP0A03 is producer type in __all__ ACPI possible devices ?
> If not we will have the same problem with others devices...
>
> I don't think blacklist is the solution : pnpacpi should be able to handle all
> ressources types : we should complete the implementation instead of blacklist
> devices our implementation doesn't support.

I agree. I don't think blacklisting PNP0A03 is the correct solution.
Any ACPI device can have a producer resource. The next time we
find a non-PNP0A03 bridge device with a producer resource, we'll
just trip over the same problem again.

Adam, Len, or Shaohua, can you explain the reason for preferring
a blacklist entry?