Re: RFC [PATCH] acpi: allow SMBus access

[Bruno Ducrot <ducrot@poupinou.org>]

On Tue, Jul 04, 2006 at 10:09:06AM +0200, Johan Vromans wrote:
> Bruno Ducrot <ducrot@poupinou.org> writes:
> 
> > I wanted to provide a real bus access via the EC driver, including
> > the interrupt driven ones.
> 
> Yes, that would be the right way to go. But it is a longer term
> solution and AFAIK noone is currently working on it.

Indeed

> In the mean time, several users can benefit from an intermediate
> solution like the one I suggested. Besides, it is not a wrong solution
> per se, it is equally wrong as the ac_read/write routines that are
> exported.

Yes, but I always considered the ec_read/write functions being an hack
in order to support sonypi at first.  If it's possible to kill them
and to replace them with the acpi_ec_read|write, well this would be
good IMHO.

> So I still think that exporting the current acpi_ec_read/write would
> be a good thing to so, but I agree it should be marked as an
> intermediate solution.

An intermediate solution would be to use the already existing
ec_read|write instead of the one you want to use.  The original
SMBus driver used acpi_ec_read because the author wanted to be
sure that driver will support laptops with more than one EC, but
he never saw such laptops so far.

Cheers,

-- 
Bruno Ducrot

--  Which is worse:  ignorance or apathy?
--  Don't know.  Don't care.