From: jayakumar.acpi@gmail.com
To: linux-acpi@vger.kernel.org, len.brown@intel.com,
dmitry.torokhov@gmail.com, akpm@osdl.org
Subject: [PATCH 2.6.17.4 1/1] ACPI: Atlas cleanup
Date: Sat, 8 Jul 2006 13:52:01 +0800 [thread overview]
Message-ID: <200607080552.k685q1ce010124@localhost.localdomain> (raw)
This patch removes legacy usage of acpi events in the Atlas ACPI driver.
Signed-off-by: Jaya Kumar <jayakumar.acpi@gmail.com>
---
Kconfig | 6 +++---
atlas_acpi.c | 16 +++-------------
2 files changed, 6 insertions(+), 16 deletions(-)
---
diff -X linux-2.6.17.4/Documentation/dontdiff -uprN linux-2.6.17.4-vanilla/drivers/acpi/atlas_acpi.c linux-2.6.17.4/drivers/acpi/atlas_acpi.c
--- linux-2.6.17.4-vanilla/drivers/acpi/atlas_acpi.c 2006-07-08 00:49:29.000000000 +0800
+++ linux-2.6.17.4/drivers/acpi/atlas_acpi.c 2006-07-08 00:49:11.000000000 +0800
@@ -26,7 +26,6 @@
#include <linux/init.h>
#include <linux/input.h>
#include <linux/types.h>
-#include <linux/proc_fs.h>
#include <asm/uaccess.h>
#include <acpi/acpi_drivers.h>
@@ -34,7 +33,6 @@
#define ACPI_ATLAS_CLASS "Atlas"
#define ACPI_ATLAS_BUTTON_HID "ASIM0000"
-#ifdef CONFIG_INPUT
static struct input_dev *input_dev;
static void atlas_input_report(u8 address)
@@ -62,7 +60,7 @@ static int atlas_setup_input(void)
}
input_dev->name = "Atlas ACPI button driver";
- input_dev->phys = "acpi/input0";
+ input_dev->phys = "ASIM0000/atlas/input0";
input_dev->id.bustype = BUS_HOST;
input_dev->evbit[LONG(EV_KEY)] = BIT(EV_KEY);
set_bit(KEY_F1, input_dev->keybit);
@@ -89,13 +87,7 @@ static void atlas_free_input(void)
{
if (input_dev)
input_unregister_device(input_dev);
-
}
-#else
-#define atlas_free_input(...)
-#define atlas_setup_input(...) 0
-#define atlas_input_report(...)
-#endif
/* button handling code */
static acpi_status acpi_atlas_button_setup(acpi_handle region_handle,
@@ -113,12 +105,10 @@ static acpi_status acpi_atlas_button_han
void *handler_context, void *region_context)
{
acpi_status status;
- struct acpi_device *dev = handler_context;
- if (function == ACPI_WRITE) {
- status = acpi_bus_generate_event(dev, 0x80, address);
+ if (function == ACPI_WRITE)
atlas_input_report((u8) address);
- } else {
+ else {
printk(KERN_WARNING "atlas: shrugged on unexpected function"
":function=%x,address=%lx,value=%x\n",
function, (unsigned long)address, (u32)*value);
diff -X linux-2.6.17.4/Documentation/dontdiff -uprN linux-2.6.17.4-vanilla/drivers/acpi/Kconfig linux-2.6.17.4/drivers/acpi/Kconfig
--- linux-2.6.17.4-vanilla/drivers/acpi/Kconfig 2006-07-08 00:49:29.000000000 +0800
+++ linux-2.6.17.4/drivers/acpi/Kconfig 2006-07-08 13:41:41.000000000 +0800
@@ -195,12 +195,12 @@ config ACPI_ASUS
config ACPI_ATLAS
tristate "Atlas Wallmount Touchscreen Extras"
- depends on X86
+ depends on X86 && INPUT
default n
---help---
This driver is intended for Atlas wallmounted touchscreens.
- The button events will show up in /proc/acpi/events and also
- as scancodes F1 through F9, and in X if you use evdev.
+ The button events will show up as scancodes F1 through F9 via
+ evdev.
If you have an Atlas wallmounted touchscreen, say Y or M here.
reply other threads:[~2006-07-08 5:53 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200607080552.k685q1ce010124@localhost.localdomain \
--to=jayakumar.acpi@gmail.com \
--cc=akpm@osdl.org \
--cc=dmitry.torokhov@gmail.com \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox