From: Keshavamurthy Anil S <anil.s.keshavamurthy@intel.com>
To: "Randy.Dunlap" <rdunlap@xenotime.net>
Cc: Keshavamurthy Anil S <anil.s.keshavamurthy@intel.com>,
Kristen Carlson Accardi <kristen.c.accardi@intel.com>,
linux-acpi@vger.kernel.org, "Brown, Len" <len.brown@intel.com>,
akpm@osdl.org, zippel@linux-m68k.org,
linux-kernel@vger.kernel.org, greg@kroah.com,
pcihpd-discuss@lists.sourceforge.net
Subject: Re: [patch] pci/hotplug acpiphp: fix Kconfig for Dock dependencies
Date: Wed, 26 Jul 2006 05:02:17 -0700 [thread overview]
Message-ID: <20060726050217.A20441@unix-os.sc.intel.com> (raw)
In-Reply-To: <Pine.LNX.4.58.0607251711020.15622@shark.he.net>; from rdunlap@xenotime.net on Tue, Jul 25, 2006 at 05:13:31PM -0700
On Tue, Jul 25, 2006 at 05:13:31PM -0700, Randy.Dunlap wrote:
> On Tue, 25 Jul 2006, Keshavamurthy Anil S wrote:
>
> > On Tue, Jul 25, 2006 at 04:18:54PM -0700, Kristen Carlson Accardi wrote:
> > > drivers/pci/hotplug/Kconfig | 17 ++++++++++++++++-
> > > 1 file changed, 16 insertions(+), 1 deletion(-)
> > Can;t this be done with just one line change?
>
> The first attempted patch was something like:
>
> depends on HOTPLUG_PCI && ACPI_DOCK!=n
>
> but that is not legal kconfig language.
> Did you have something else in mind?
Yup, already mentioned in my first email.
Please see below which is just one line change
and acheives the same as your 17 line change patch.
> > > - depends on ACPI_DOCK && HOTPLUG_PCI
> > depends on (!ACPI_DOCK && ACPI && HOTPLUG_PCI) || (ACPI_DOCK && HOTPLUG_PCI)
-Anil
next prev parent reply other threads:[~2006-07-26 12:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-25 23:18 [patch] pci/hotplug acpiphp: fix Kconfig for Dock dependencies Kristen Carlson Accardi
2006-07-25 23:41 ` Keshavamurthy Anil S
2006-07-26 0:13 ` Randy.Dunlap
2006-07-26 12:02 ` Keshavamurthy Anil S [this message]
2006-07-26 17:32 ` Kristen Carlson Accardi
2006-07-27 0:23 ` Roman Zippel
-- strict thread matches above, loose matches on Subject: below --
2006-08-16 4:59 Brown, Len
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060726050217.A20441@unix-os.sc.intel.com \
--to=anil.s.keshavamurthy@intel.com \
--cc=akpm@osdl.org \
--cc=greg@kroah.com \
--cc=kristen.c.accardi@intel.com \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pcihpd-discuss@lists.sourceforge.net \
--cc=rdunlap@xenotime.net \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox