public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Pavel Machek <pavel@suse.cz>
Cc: Andrew Morton <akpm@osdl.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Linux ACPI <linux-acpi@vger.kernel.org>
Subject: Re: 2.6.18-rc4 (and earlier): CMOS clock corruption during suspend to disk on i386
Date: Mon, 14 Aug 2006 10:41:59 +0200	[thread overview]
Message-ID: <200608141041.59410.rjw@sisk.pl> (raw)
In-Reply-To: <20060813223354.GF6231@elf.ucw.cz>

On Monday 14 August 2006 00:33, Pavel Machek wrote:
> On Thu 2006-08-10 22:51:20, Rafael J. Wysocki wrote:
]--snip--[
> > > > > BTW, it's a dangerous setting, because some drivers get mad if the time after
> > > > > the resume appears to be earlier than the time before the suspend.  Also the
> > > > > timer .suspend/.resume routines aren't prepared for that.
> > > > 
> > > > Its config option should just go away. People comfortable using *that*
> > > > should just edit some header file. Rafael, could you do patch doing
> > > > something like that?
> > > 
> > > Just remove the option from Kconfig or the whole setting?
> > > 
> > > Shouldn't we also change the timer .resume() routines to check if the time
> > > after the resume is later than (or at least the same as) the time before the
> > > suspend and set the "sleep length" to 0 if not?
> > 
> > Hm, I'm thinking it may actually be useful to have in Kconfig and if we change
> > the timer resume to detect the dangerous situation and prevent it from
> > happening, that should be sufficient.
> 
> Well, it is still too easy to shoot yourself in the foot. Your time
> will be wrong if you enable innocent-sounding option.

We can add DANGEROUS to it. :-)

Rafael

  reply	other threads:[~2006-08-14  8:43 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-09 12:26 2.6.18-rc4 (and earlier): CMOS clock corruption during suspend to disk on i386 Rafael J. Wysocki
2006-08-09 12:30 ` Pavel Machek
2006-08-09 20:01   ` Rafael J. Wysocki
2006-08-09 20:12     ` Andrew Morton
2006-08-09 20:51       ` Rafael J. Wysocki
2006-08-10  0:12         ` Pavel Machek
2006-08-10 12:15           ` Rafael J. Wysocki
2006-08-10 20:51             ` Rafael J. Wysocki
2006-08-12 19:08               ` Jesse Brandeburg
2006-08-12 19:11                 ` Rafael J. Wysocki
2006-08-13 22:33               ` Pavel Machek
2006-08-14  8:41                 ` Rafael J. Wysocki [this message]
2006-08-13 22:33             ` Pavel Machek
2006-08-09 17:44 ` john stultz
2006-08-09 20:04   ` Rafael J. Wysocki
2006-08-09 20:13     ` john stultz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200608141041.59410.rjw@sisk.pl \
    --to=rjw@sisk.pl \
    --cc=akpm@osdl.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pavel@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox