* drivers/acpi/sbs.c:acpi_sbs_remove() inconsistent NULL checking
@ 2006-08-14 22:48 Adrian Bunk
0 siblings, 0 replies; only message in thread
From: Adrian Bunk @ 2006-08-14 22:48 UTC (permalink / raw)
To: Rich Townsend; +Cc: len.brown, linux-acpi, linux-kernel
The Coverity checker spotted the following inconsistent NULL checking
introduced by commit 3f86b83243d59bb50caf5938d284d22e10d082a4:
<-- snip -->
...
int acpi_sbs_remove(struct acpi_device *device, int type)
{
struct acpi_sbs *sbs = (struct acpi_sbs *)acpi_driver_data(device);
int id;
if (!device || !sbs) {
return -EINVAL;
}
...
<-- snip -->
The NULL check for "device" is three lines after it got dereferenced the
first time.
cu
Adrian
--
Gentoo kernels are 42 times more popular than SUSE kernels among
KLive users (a service by SUSE contractor Andrea Arcangeli that
gathers data about kernels from many users worldwide).
There are three kinds of lies: Lies, Damn Lies, and Statistics.
Benjamin Disraeli
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2006-08-14 22:48 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-08-14 22:48 drivers/acpi/sbs.c:acpi_sbs_remove() inconsistent NULL checking Adrian Bunk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox