From: Len Brown <len.brown@intel.com>
To: akpm@osdl.org
Cc: linux-acpi@vger.kernel.org, jayakumar.acpi@gmail.com,
dtor_core@ameritech.net, luming.yu@intel.com
Subject: Re: [patch 02/14] ACPI: Atlas ACPI driver
Date: Tue, 15 Aug 2006 23:13:56 -0400 [thread overview]
Message-ID: <200608152313.56558.len.brown@intel.com> (raw)
In-Reply-To: <200608150537.k7F5bMHZ011530@shell0.pdx.osdl.net>
Andrew,
Please delete this patch from MM -- it is stale.
Jaya, please send Andrew the newer patch that replaces it -- the one
that doesn't touch drivers/acpi.
thanks,
-Len
On Tuesday 15 August 2006 01:37, akpm@osdl.org wrote:
> From: Jaya Kumar <jayakumar.acpi@gmail.com>
>
> An ACPI driver for Atlas boards, including input support.
>
> Signed-off-by: Jaya Kumar <jayakumar.acpi@gmail.com>
> Cc: "Brown, Len" <len.brown@intel.com>
> Cc: Dmitry Torokhov <dtor_core@ameritech.net>
> Cc: "Yu, Luming" <luming.yu@intel.com>
> Signed-off-by: Andrew Morton <akpm@osdl.org>
> ---
>
> drivers/acpi/Kconfig | 13 ++
> drivers/acpi/Makefile | 1
> drivers/acpi/atlas_acpi.c | 181 ++++++++++++++++++++++++++++++++++++
> 3 files changed, 194 insertions(+), 1 deletion(-)
>
> diff -puN drivers/acpi/Kconfig~acpi-atlas-acpi-driver drivers/acpi/Kconfig
> --- a/drivers/acpi/Kconfig~acpi-atlas-acpi-driver
> +++ a/drivers/acpi/Kconfig
> @@ -196,7 +196,18 @@ config ACPI_ASUS
> driver is still under development, so if your laptop is unsupported or
> something works not quite as expected, please use the mailing list
> available on the above page (acpi4asus-user@lists.sourceforge.net)
> -
> +
> +config ACPI_ATLAS
> + tristate "Atlas Wallmount Touchscreen Extras"
> + depends on X86 && INPUT
> + default n
> + ---help---
> + This driver is intended for Atlas wallmounted touchscreens.
> + The button events will show up as scancodes F1 through F9 via
> + evdev.
> +
> + If you have an Atlas wallmounted touchscreen, say Y or M here.
> +
> config ACPI_IBM
> tristate "IBM ThinkPad Laptop Extras"
> depends on X86
> diff -puN drivers/acpi/Makefile~acpi-atlas-acpi-driver drivers/acpi/Makefile
> --- a/drivers/acpi/Makefile~acpi-atlas-acpi-driver
> +++ a/drivers/acpi/Makefile
> @@ -54,6 +54,7 @@ obj-$(CONFIG_ACPI_SYSTEM) += system.o ev
> obj-$(CONFIG_ACPI_DEBUG) += debug.o
> obj-$(CONFIG_ACPI_NUMA) += numa.o
> obj-$(CONFIG_ACPI_ASUS) += asus_acpi.o
> +obj-$(CONFIG_ACPI_ATLAS) += atlas_acpi.o
> obj-$(CONFIG_ACPI_IBM) += ibm_acpi.o
> obj-$(CONFIG_ACPI_TOSHIBA) += toshiba_acpi.o
> obj-y += scan.o motherboard.o
> diff -puN /dev/null drivers/acpi/atlas_acpi.c
> --- /dev/null
> +++ a/drivers/acpi/atlas_acpi.c
> @@ -0,0 +1,181 @@
> +/*
> + * atlas_acpi.c - Atlas Wallmount Touchscreen ACPI Extras
> + *
> + * Copyright (C) 2006 Jaya Kumar
> + * Based on Toshiba ACPI by John Belmonte and ASUS ACPI
> + * This work was sponsored by CIS(M) Sdn Bhd.
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write to the Free Software
> + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
> + *
> + */
> +
> +#include <linux/kernel.h>
> +#include <linux/module.h>
> +#include <linux/init.h>
> +#include <linux/input.h>
> +#include <linux/types.h>
> +#include <asm/uaccess.h>
> +#include <acpi/acpi_drivers.h>
> +
> +#define ACPI_ATLAS_NAME "Atlas ACPI"
> +#define ACPI_ATLAS_CLASS "Atlas"
> +#define ACPI_ATLAS_BUTTON_HID "ASIM0000"
> +
> +static struct input_dev *input_dev;
> +
> +static void atlas_input_report(u8 address)
> +{
> + int keycode;
> +
> + keycode = KEY_F1 + (address & 0x0F);
> +
> + if (address & 0x10)
> + input_report_key(input_dev, keycode, 0);
> + else
> + input_report_key(input_dev, keycode, 1);
> + input_sync(input_dev);
> +}
> +
> +static int atlas_setup_input(void)
> +{
> + int err;
> +
> + input_dev = input_allocate_device();
> + if (!input_dev) {
> + printk(KERN_ERR "atlas: insufficient mem to allocate input "
> + "device\n");
> + return -ENOMEM;
> + }
> +
> + input_dev->name = "Atlas ACPI button driver";
> + input_dev->phys = "ASIM0000/atlas/input0";
> + input_dev->id.bustype = BUS_HOST;
> + input_dev->evbit[LONG(EV_KEY)] = BIT(EV_KEY);
> + set_bit(KEY_F1, input_dev->keybit);
> + set_bit(KEY_F2, input_dev->keybit);
> + set_bit(KEY_F3, input_dev->keybit);
> + set_bit(KEY_F4, input_dev->keybit);
> + set_bit(KEY_F5, input_dev->keybit);
> + set_bit(KEY_F6, input_dev->keybit);
> + set_bit(KEY_F7, input_dev->keybit);
> + set_bit(KEY_F8, input_dev->keybit);
> + set_bit(KEY_F9, input_dev->keybit);
> +
> + err = input_register_device(input_dev);
> + if (err) {
> + printk(KERN_ERR "atlas: couldn't register input device\n");
> + input_free_device(input_dev);
> + return err;
> + }
> +
> + return 0;
> +}
> +
> +static void atlas_free_input(void)
> +{
> + if (input_dev)
> + input_unregister_device(input_dev);
> +}
> +
> +/* button handling code */
> +static acpi_status acpi_atlas_button_setup(acpi_handle region_handle,
> + u32 function, void *handler_context, void **return_context)
> +{
> + *return_context =
> + (function != ACPI_REGION_DEACTIVATE) ? handler_context : NULL;
> +
> + return AE_OK;
> +}
> +
> +static acpi_status acpi_atlas_button_handler(u32 function,
> + acpi_physical_address address,
> + u32 bit_width, acpi_integer *value,
> + void *handler_context, void *region_context)
> +{
> + acpi_status status;
> +
> + if (function == ACPI_WRITE)
> + atlas_input_report((u8) address);
> + else {
> + printk(KERN_WARNING "atlas: shrugged on unexpected function"
> + ":function=%x,address=%lx,value=%x\n",
> + function, (unsigned long)address, (u32)*value);
> + status = -EINVAL;
> + }
> +
> + return status;
> +}
> +
> +static int atlas_acpi_button_add(struct acpi_device *device)
> +{
> + int err;
> +
> + err = atlas_setup_input();
> + if (err)
> + return err;
> +
> + /* hookup button handler */
> + return acpi_install_address_space_handler(device->handle,
> + 0x81, &acpi_atlas_button_handler,
> + &acpi_atlas_button_setup, device);
> +}
> +
> +static int atlas_acpi_button_remove(struct acpi_device *device, int type)
> +{
> + acpi_status status;
> +
> + status = acpi_remove_address_space_handler(device->handle,
> + 0x81, &acpi_atlas_button_handler);
> + if (ACPI_FAILURE(status))
> + printk(KERN_ERR "Atlas: Error removing addr spc handler\n");
> + atlas_free_input();
> + return status;
> +}
> +
> +static struct acpi_driver atlas_acpi_driver = {
> + .name = ACPI_ATLAS_NAME,
> + .class = ACPI_ATLAS_CLASS,
> + .ids = ACPI_ATLAS_BUTTON_HID,
> + .ops = {
> + .add = atlas_acpi_button_add,
> + .remove = atlas_acpi_button_remove,
> + },
> +};
> +
> +static int atlas_acpi_init(void)
> +{
> + int result;
> +
> + result = acpi_bus_register_driver(&atlas_acpi_driver);
> + if (result < 0) {
> + printk(KERN_ERR "Atlas ACPI: Unable to register driver\n");
> + return -ENODEV;
> + }
> +
> + return 0;
> +}
> +
> +static void atlas_acpi_exit(void)
> +{
> + acpi_bus_unregister_driver(&atlas_acpi_driver);
> +}
> +
> +module_init(atlas_acpi_init);
> +module_exit(atlas_acpi_exit);
> +
> +MODULE_AUTHOR("Jaya Kumar");
> +MODULE_LICENSE("GPL");
> +MODULE_DESCRIPTION("Atlas ACPI");
> +
> _
> -
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2006-08-16 3:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-15 5:37 [patch 02/14] ACPI: Atlas ACPI driver akpm
2006-08-16 3:13 ` Len Brown [this message]
2006-08-17 7:48 ` Jaya Kumar
2006-08-18 14:44 ` Len Brown
2006-08-23 17:49 ` Dmitry Torokhov
2007-01-11 5:16 ` Jaya Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200608152313.56558.len.brown@intel.com \
--to=len.brown@intel.com \
--cc=akpm@osdl.org \
--cc=dtor_core@ameritech.net \
--cc=jayakumar.acpi@gmail.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=luming.yu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox