From: Len Brown <len.brown@intel.com>
To: William Morrow <William.Morrow@amd.com>
Cc: Len Brown <lenb@kernel.org>,
akpm@osdl.org, linux-acpi@vger.kernel.org, jordan.crouse@amd.com,
luming.yu@intel.com
Subject: Re: [patch 13/14] ACPI: Correctly recover from a failed S3 attempt
Date: Wed, 16 Aug 2006 17:55:08 -0400 [thread overview]
Message-ID: <200608161755.08809.len.brown@intel.com> (raw)
In-Reply-To: <44E35CCB.5010109@amd.com>
On Wednesday 16 August 2006 13:58, William Morrow wrote:
> >>This was discovered on a broken BIOS that simply returned from its suspend
> >>procedure, appearing to the OS as a failed S3 attempt.
> > [ acpi_enter_sleep_state() ]...
> does not actually bail out, it just returns do_suspend_lowlevel as if
> it did sleep. It did sleep, but did not restart and return the call by the accepted
> software mechanism.
> The machine resumes execution in protected mode with the original
> machine state largely intact, but it fails to restore the sysenter/exit registers.
> >Does S3 work on windows on this box?
> >
> Yes (XP). This is the excuse - and is the force which is driving this solution.
> There is no test group to re-test all of the ACPI aware OSs S3 recovery.
> So if they change (correct) the S3 strategy, it cant be well tested
> here. Since it was tested in the errant form and appeared to pass (on XP), there is
> considerable pressure to not correct the bios.
William,
This is an excellent discovery.
It is proof that Windows handles this deviant case -- and so if we fix Linux to handle it,
then we may fix other failing systems.
thanks,
-Len
next prev parent reply other threads:[~2006-08-16 21:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-15 5:37 [patch 13/14] ACPI: Correctly recover from a failed S3 attempt akpm
2006-08-16 4:27 ` Len Brown
2006-08-16 17:58 ` William Morrow
2006-08-16 21:55 ` Len Brown [this message]
2006-08-16 22:00 ` Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200608161755.08809.len.brown@intel.com \
--to=len.brown@intel.com \
--cc=William.Morrow@amd.com \
--cc=akpm@osdl.org \
--cc=jordan.crouse@amd.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=luming.yu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).