From: Andrew Morton <akpm@osdl.org>
To: Lennart Poettering <mzxreary@0pointer.de>
Cc: len.brown@intel.com, linux-kernel@vger.kernel.org,
linux-acpi@vger.kernel.org
Subject: Re: [PATCH] acpi: ec_transaction(), second try
Date: Mon, 21 Aug 2006 15:52:58 -0700 [thread overview]
Message-ID: <20060821155258.21bebc10.akpm@osdl.org> (raw)
In-Reply-To: <20060820222759.GA5369@curacao>
On Mon, 21 Aug 2006 00:27:59 +0200
Lennart Poettering <mzxreary@0pointer.de> wrote:
> This is the second version of my patch which unifies the logic of
> ec_read() and ec_write() into ec_transaction(). Most things I wrote
> about the first version are still true:
>
> http://marc.theaimsgroup.com/?l=linux-kernel&m=115517205307700&w=2
>
> The changes are:
>
> - Updated for Kernel 2.6.18pre (Linus' GIT tree as of today)
>
> - Fix a bad argument validity check in acpi_ec_poll_transaction() as
> pointed out by Yu Luming.
>
> - I unified the code in acpi_ec_poll_transaction() and
> acpi_ec_intr_transaction() a little more. Both functions are now just
> wrappers around the new acpi_ec_transaction_unlocked() function. The
> latter contains the EC access logic, the two original
> function now just do their special way of locking and call the the
> new function for the actual work.
>
> This patch is required for my MSI laptop support patch.
>
> Based on Linus' GIT tree and should also apply to the current ACPI
> tree.
This isn't a suitable description of this work. Please review
http://www.zip.com.au/~akpm/linux/patches/stuff/tpp.txt, especially section
4 and then send (and maintain) a new changelog, thanks.
prev parent reply other threads:[~2006-08-21 22:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-20 22:27 [PATCH] acpi: ec_transaction(), second try Lennart Poettering
2006-08-21 22:52 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060821155258.21bebc10.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mzxreary@0pointer.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox