From: Andrew Morton <akpm@osdl.org>
To: Lennart Poettering <mzxreary@0pointer.de>
Cc: len.brown@intel.com, rubini@vision.unipv.it, pavel@suse.cz,
linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: Re: [PATCH] misc,acpi,backlight: MSI S270 Laptop support, third try
Date: Mon, 21 Aug 2006 15:58:31 -0700 [thread overview]
Message-ID: <20060821155831.daa8425e.akpm@osdl.org> (raw)
In-Reply-To: <20060820225209.GA5453@curacao>
On Mon, 21 Aug 2006 00:52:09 +0200
Lennart Poettering <mzxreary@0pointer.de> wrote:
> +static ssize_t store_auto_brightness(
> + struct device *dev,
> + struct device_attribute *attr,
> + const char *buf, size_t count) {
> +
> + int enable, ret;
Please follow the usual kernel coding style, which would yield something like:
static ssize_t store_auto_brightness(struct device *dev,
struct device_attribute *attr, const char *buf, size_t count)
{
int enable, ret;
(affects entire patch).
And please also prepare and maintain a standalone changelog. The one you have here
is full of references to some long-gone email. Think: "how will my changelog look
when it is in the main git tree".
Thanks.
next prev parent reply other threads:[~2006-08-21 22:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-20 22:52 [PATCH] misc,acpi,backlight: MSI S270 Laptop support, third try Lennart Poettering
2006-08-21 22:58 ` Andrew Morton [this message]
2006-08-24 5:52 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060821155831.daa8425e.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mzxreary@0pointer.de \
--cc=pavel@suse.cz \
--cc=rubini@vision.unipv.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox