From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Randy.Dunlap" Subject: Re: [-mm patch] ACPI_SONY shouldn't default m Date: Wed, 6 Sep 2006 21:41:45 -0700 Message-ID: <20060906214145.95403569.rdunlap@xenotime.net> References: <20060901015818.42767813.akpm@osdl.org> <20060906230700.GE12157@stusta.de> <20060906203003.95ad130a.akpm@osdl.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from xenotime.net ([66.160.160.81]:41635 "HELO xenotime.net") by vger.kernel.org with SMTP id S1161074AbWIGEiJ (ORCPT ); Thu, 7 Sep 2006 00:38:09 -0400 Received: from midway.site ([71.117.233.155]) by xenotime.net for ; Wed, 6 Sep 2006 21:38:08 -0700 In-Reply-To: <20060906203003.95ad130a.akpm@osdl.org> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Andrew Morton Cc: Adrian Bunk , Bjorn Helgaas , Stelian Pop , linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org On Wed, 6 Sep 2006 20:30:03 -0700 Andrew Morton wrote: > On Thu, 7 Sep 2006 01:07:00 +0200 > Adrian Bunk wrote: > > > Drivers should default to n. > > > > Signed-off-by: Adrian Bunk > > > > --- linux-2.6.18-rc5-mm1/drivers/acpi/Kconfig.old 2006-09-07 00:49:37.000000000 +0200 > > +++ linux-2.6.18-rc5-mm1/drivers/acpi/Kconfig 2006-09-07 00:50:01.000000000 +0200 > > @@ -251,7 +251,6 @@ > > config ACPI_SONY > > tristate "Sony Laptop Extras" > > depends on X86 && ACPI > > - default m > > Not this one - I need it on my Vaio and I get sick of the option vanishing. > Make it depend on CONFIG_AKPM? I'll ack that one. :) otherwise I also agree with Adrian's patch... --- ~Randy