* [Fwd: [patch 2.6.18-rc7] ACPI: build warnings begone (x86_64)]
@ 2006-09-20 1:29 Sergio Monteiro Basto
0 siblings, 0 replies; 5+ messages in thread
From: Sergio Monteiro Basto @ 2006-09-20 1:29 UTC (permalink / raw)
To: acpi devel; +Cc: David Brownell
[-- Attachment #1: Type: text/plain, Size: 3756 bytes --]
Hi, I think this should be reported on
ACPI mailing list , so I am Forwarding to this list
-------- Forwarded Message --------
> From: David Brownell <david-b@pacbell.net>
> To: Brown, Len <len.brown@intel.com>
> Cc: linux-kernel@vger.kernel.org
> Subject: [patch 2.6.18-rc7] ACPI: build warnings begone (x86_64)
> Date: Wed, 13 Sep 2006 21:00:33 -0700
>
> This makes various ACPI compiler warnings go away (x86_64),
> making builds be warning-free again.
>
> Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
>
> Index: g26/drivers/acpi/executer/exmutex.c
> ===================================================================
> --- g26.orig/drivers/acpi/executer/exmutex.c 2006-07-14 10:03:04.000000000 -0700
> +++ g26/drivers/acpi/executer/exmutex.c 2006-09-13 13:31:10.000000000 -0700
> @@ -266,10 +266,10 @@ acpi_ex_release_mutex(union acpi_operand
> walk_state->thread->thread_id)
> && (obj_desc->mutex.os_mutex != ACPI_GLOBAL_LOCK)) {
> ACPI_ERROR((AE_INFO,
> - "Thread %X cannot release Mutex [%4.4s] acquired by thread %X",
> - (u32) walk_state->thread->thread_id,
> + "Thread %p cannot release Mutex [%4.4s] acquired by thread %p",
> + walk_state->thread->thread_id,
> acpi_ut_get_node_name(obj_desc->mutex.node),
> - (u32) obj_desc->mutex.owner_thread->thread_id));
> + obj_desc->mutex.owner_thread->thread_id));
> return_ACPI_STATUS(AE_AML_NOT_OWNER);
> }
>
> Index: g26/drivers/acpi/tables/tbget.c
> ===================================================================
> --- g26.orig/drivers/acpi/tables/tbget.c 2006-07-14 10:03:04.000000000 -0700
> +++ g26/drivers/acpi/tables/tbget.c 2006-09-13 13:37:27.000000000 -0700
> @@ -324,7 +324,7 @@ acpi_tb_get_this_table(struct acpi_point
>
> if (header->length < sizeof(struct acpi_table_header)) {
> ACPI_ERROR((AE_INFO,
> - "Table length (%X) is smaller than minimum (%X)",
> + "Table length (%X) is smaller than minimum (%zX)",
> header->length, sizeof(struct acpi_table_header)));
>
> return_ACPI_STATUS(AE_INVALID_TABLE_LENGTH);
> Index: g26/drivers/acpi/utilities/utmutex.c
> ===================================================================
> --- g26.orig/drivers/acpi/utilities/utmutex.c 2006-07-14 10:03:04.000000000 -0700
> +++ g26/drivers/acpi/utilities/utmutex.c 2006-09-13 13:39:24.000000000 -0700
> @@ -258,8 +258,8 @@ acpi_status acpi_ut_acquire_mutex(acpi_m
> acpi_gbl_mutex_info[mutex_id].thread_id = this_thread_id;
> } else {
> ACPI_EXCEPTION((AE_INFO, status,
> - "Thread %X could not acquire Mutex [%X]",
> - (u32) this_thread_id, mutex_id));
> + "Thread %p could not acquire Mutex [%X]",
> + this_thread_id, mutex_id));
> }
>
> return (status);
> Index: g26/drivers/acpi/tables/tbrsdt.c
> ===================================================================
> --- g26.orig/drivers/acpi/tables/tbrsdt.c 2006-07-14 10:03:04.000000000 -0700
> +++ g26/drivers/acpi/tables/tbrsdt.c 2006-09-13 13:38:39.000000000 -0700
> @@ -187,7 +187,7 @@ acpi_status acpi_tb_validate_rsdt(struct
>
> if (table_ptr->length < sizeof(struct acpi_table_header)) {
> ACPI_ERROR((AE_INFO,
> - "RSDT/XSDT length (%X) is smaller than minimum (%X)",
> + "RSDT/XSDT length (%X) is smaller than minimum (%zX)",
> table_ptr->length,
> sizeof(struct acpi_table_header)));
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
Sérgio M.B.
[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 2166 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [Fwd: [patch 2.6.18-rc7] ACPI: build warnings begone (x86_64)]
@ 2006-09-20 15:11 Moore, Robert
2006-09-20 15:49 ` David Brownell
2006-09-20 16:49 ` Alexey Starikovskiy
0 siblings, 2 replies; 5+ messages in thread
From: Moore, Robert @ 2006-09-20 15:11 UTC (permalink / raw)
To: sergio, acpi devel; +Cc: David Brownell
Problem is to make one version of the code compile everywhere with no warnings.
> -----Original Message-----
> From: linux-acpi-owner@vger.kernel.org [mailto:linux-acpi-
> owner@vger.kernel.org] On Behalf Of Sergio Monteiro Basto
> Sent: Tuesday, September 19, 2006 6:30 PM
> To: acpi devel
> Cc: David Brownell
> Subject: [Fwd: [patch 2.6.18-rc7] ACPI: build warnings begone (x86_64)]
>
> Hi, I think this should be reported on
> ACPI mailing list , so I am Forwarding to this list
>
> -------- Forwarded Message --------
> > From: David Brownell <david-b@pacbell.net>
> > To: Brown, Len <len.brown@intel.com>
> > Cc: linux-kernel@vger.kernel.org
> > Subject: [patch 2.6.18-rc7] ACPI: build warnings begone (x86_64)
> > Date: Wed, 13 Sep 2006 21:00:33 -0700
> >
> > This makes various ACPI compiler warnings go away (x86_64),
> > making builds be warning-free again.
> >
> > Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
> >
> > Index: g26/drivers/acpi/executer/exmutex.c
> > ===================================================================
> > --- g26.orig/drivers/acpi/executer/exmutex.c 2006-07-14
> 10:03:04.000000000 -0700
> > +++ g26/drivers/acpi/executer/exmutex.c 2006-09-13 13:31:10.000000000 -
> 0700
> > @@ -266,10 +266,10 @@ acpi_ex_release_mutex(union acpi_operand
> > walk_state->thread->thread_id)
> > && (obj_desc->mutex.os_mutex != ACPI_GLOBAL_LOCK)) {
> > ACPI_ERROR((AE_INFO,
> > - "Thread %X cannot release Mutex [%4.4s] acquired by
> thread %X",
> > - (u32) walk_state->thread->thread_id,
> > + "Thread %p cannot release Mutex [%4.4s] acquired by
> thread %p",
> > + walk_state->thread->thread_id,
> > acpi_ut_get_node_name(obj_desc->mutex.node),
> > - (u32) obj_desc->mutex.owner_thread->thread_id));
> > + obj_desc->mutex.owner_thread->thread_id));
> > return_ACPI_STATUS(AE_AML_NOT_OWNER);
> > }
> >
> > Index: g26/drivers/acpi/tables/tbget.c
> > ===================================================================
> > --- g26.orig/drivers/acpi/tables/tbget.c 2006-07-14
> 10:03:04.000000000 -0700
> > +++ g26/drivers/acpi/tables/tbget.c 2006-09-13 13:37:27.000000000 -
> 0700
> > @@ -324,7 +324,7 @@ acpi_tb_get_this_table(struct acpi_point
> >
> > if (header->length < sizeof(struct acpi_table_header)) {
> > ACPI_ERROR((AE_INFO,
> > - "Table length (%X) is smaller than minimum (%X)",
> > + "Table length (%X) is smaller than minimum (%zX)",
> > header->length, sizeof(struct acpi_table_header)));
> >
> > return_ACPI_STATUS(AE_INVALID_TABLE_LENGTH);
> > Index: g26/drivers/acpi/utilities/utmutex.c
> > ===================================================================
> > --- g26.orig/drivers/acpi/utilities/utmutex.c 2006-07-14
> 10:03:04.000000000 -0700
> > +++ g26/drivers/acpi/utilities/utmutex.c 2006-09-13
> 13:39:24.000000000 -0700
> > @@ -258,8 +258,8 @@ acpi_status acpi_ut_acquire_mutex(acpi_m
> > acpi_gbl_mutex_info[mutex_id].thread_id = this_thread_id;
> > } else {
> > ACPI_EXCEPTION((AE_INFO, status,
> > - "Thread %X could not acquire Mutex [%X]",
> > - (u32) this_thread_id, mutex_id));
> > + "Thread %p could not acquire Mutex [%X]",
> > + this_thread_id, mutex_id));
> > }
> >
> > return (status);
> > Index: g26/drivers/acpi/tables/tbrsdt.c
> > ===================================================================
> > --- g26.orig/drivers/acpi/tables/tbrsdt.c 2006-07-14
> 10:03:04.000000000 -0700
> > +++ g26/drivers/acpi/tables/tbrsdt.c 2006-09-13 13:38:39.000000000 -
> 0700
> > @@ -187,7 +187,7 @@ acpi_status acpi_tb_validate_rsdt(struct
> >
> > if (table_ptr->length < sizeof(struct acpi_table_header)) {
> > ACPI_ERROR((AE_INFO,
> > - "RSDT/XSDT length (%X) is smaller than minimum
> (%X)",
> > + "RSDT/XSDT length (%X) is smaller than minimum
> (%zX)",
> > table_ptr->length,
> > sizeof(struct acpi_table_header)));
> >
> > -
> > To unsubscribe from this list: send the line "unsubscribe linux-kernel"
> in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> > Please read the FAQ at http://www.tux.org/lkml/
> --
> Sérgio M.B.
-
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Fwd: [patch 2.6.18-rc7] ACPI: build warnings begone (x86_64)]
2006-09-20 15:11 [Fwd: [patch 2.6.18-rc7] ACPI: build warnings begone (x86_64)] Moore, Robert
@ 2006-09-20 15:49 ` David Brownell
2006-09-20 16:49 ` Alexey Starikovskiy
1 sibling, 0 replies; 5+ messages in thread
From: David Brownell @ 2006-09-20 15:49 UTC (permalink / raw)
To: Moore, Robert; +Cc: sergio, acpi devel
On Wednesday 20 September 2006 8:11 am, Moore, Robert wrote:
> Problem is to make one version of the code compile everywhere with no warnings.
Yes, and it's been solved in essentially all other parts of x86 kernels.
In fact, until somewhere in the 2.6.18 series it was solved for ACPI ...
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [Fwd: [patch 2.6.18-rc7] ACPI: build warnings begone (x86_64)]
@ 2006-09-20 15:55 Moore, Robert
0 siblings, 0 replies; 5+ messages in thread
From: Moore, Robert @ 2006-09-20 15:55 UTC (permalink / raw)
To: David Brownell; +Cc: sergio, acpi devel
Yes, ACPICA started to allow more native kernel data types to be
compiled into itself, breaking many of the existing debug output
statements.
> -----Original Message-----
> From: linux-acpi-owner@vger.kernel.org [mailto:linux-acpi-
> owner@vger.kernel.org] On Behalf Of David Brownell
> Sent: Wednesday, September 20, 2006 8:50 AM
> To: Moore, Robert
> Cc: sergio@sergiomb.no-ip.org; acpi devel
> Subject: Re: [Fwd: [patch 2.6.18-rc7] ACPI: build warnings begone
> (x86_64)]
>
> On Wednesday 20 September 2006 8:11 am, Moore, Robert wrote:
> > Problem is to make one version of the code compile everywhere with
no
> warnings.
>
> Yes, and it's been solved in essentially all other parts of x86
kernels.
> In fact, until somewhere in the 2.6.18 series it was solved for ACPI
...
>
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-acpi"
in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Fwd: [patch 2.6.18-rc7] ACPI: build warnings begone (x86_64)]
2006-09-20 15:11 [Fwd: [patch 2.6.18-rc7] ACPI: build warnings begone (x86_64)] Moore, Robert
2006-09-20 15:49 ` David Brownell
@ 2006-09-20 16:49 ` Alexey Starikovskiy
1 sibling, 0 replies; 5+ messages in thread
From: Alexey Starikovskiy @ 2006-09-20 16:49 UTC (permalink / raw)
To: Moore, Robert; +Cc: sergio, acpi devel, David Brownell
print expects C types, so conversion to them helps (use (unsigned) for %X or (unsigned long) for %lX).
Regards,
Alex.
Moore, Robert wrote:
> Problem is to make one version of the code compile everywhere with no warnings.
>
>> -----Original Message-----
>> From: linux-acpi-owner@vger.kernel.org [mailto:linux-acpi-
>> owner@vger.kernel.org] On Behalf Of Sergio Monteiro Basto
>> Sent: Tuesday, September 19, 2006 6:30 PM
>> To: acpi devel
>> Cc: David Brownell
>> Subject: [Fwd: [patch 2.6.18-rc7] ACPI: build warnings begone (x86_64)]
>>
>> Hi, I think this should be reported on
>> ACPI mailing list , so I am Forwarding to this list
>>
>> -------- Forwarded Message --------
>>> From: David Brownell <david-b@pacbell.net>
>>> To: Brown, Len <len.brown@intel.com>
>>> Cc: linux-kernel@vger.kernel.org
>>> Subject: [patch 2.6.18-rc7] ACPI: build warnings begone (x86_64)
>>> Date: Wed, 13 Sep 2006 21:00:33 -0700
>>>
>>> This makes various ACPI compiler warnings go away (x86_64),
>>> making builds be warning-free again.
>>>
>>> Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
>>>
>>> Index: g26/drivers/acpi/executer/exmutex.c
>>> ===================================================================
>>> --- g26.orig/drivers/acpi/executer/exmutex.c 2006-07-14
>> 10:03:04.000000000 -0700
>>> +++ g26/drivers/acpi/executer/exmutex.c 2006-09-13 13:31:10.000000000 -
>> 0700
>>> @@ -266,10 +266,10 @@ acpi_ex_release_mutex(union acpi_operand
>>> walk_state->thread->thread_id)
>>> && (obj_desc->mutex.os_mutex != ACPI_GLOBAL_LOCK)) {
>>> ACPI_ERROR((AE_INFO,
>>> - "Thread %X cannot release Mutex [%4.4s] acquired by
>> thread %X",
>>> - (u32) walk_state->thread->thread_id,
>>> + "Thread %p cannot release Mutex [%4.4s] acquired by
>> thread %p",
>>> + walk_state->thread->thread_id,
>>> acpi_ut_get_node_name(obj_desc->mutex.node),
>>> - (u32) obj_desc->mutex.owner_thread->thread_id));
>>> + obj_desc->mutex.owner_thread->thread_id));
>>> return_ACPI_STATUS(AE_AML_NOT_OWNER);
>>> }
>>>
>>> Index: g26/drivers/acpi/tables/tbget.c
>>> ===================================================================
>>> --- g26.orig/drivers/acpi/tables/tbget.c 2006-07-14
>> 10:03:04.000000000 -0700
>>> +++ g26/drivers/acpi/tables/tbget.c 2006-09-13 13:37:27.000000000 -
>> 0700
>>> @@ -324,7 +324,7 @@ acpi_tb_get_this_table(struct acpi_point
>>>
>>> if (header->length < sizeof(struct acpi_table_header)) {
>>> ACPI_ERROR((AE_INFO,
>>> - "Table length (%X) is smaller than minimum (%X)",
>>> + "Table length (%X) is smaller than minimum (%zX)",
>>> header->length, sizeof(struct acpi_table_header)));
>>>
>>> return_ACPI_STATUS(AE_INVALID_TABLE_LENGTH);
>>> Index: g26/drivers/acpi/utilities/utmutex.c
>>> ===================================================================
>>> --- g26.orig/drivers/acpi/utilities/utmutex.c 2006-07-14
>> 10:03:04.000000000 -0700
>>> +++ g26/drivers/acpi/utilities/utmutex.c 2006-09-13
>> 13:39:24.000000000 -0700
>>> @@ -258,8 +258,8 @@ acpi_status acpi_ut_acquire_mutex(acpi_m
>>> acpi_gbl_mutex_info[mutex_id].thread_id = this_thread_id;
>>> } else {
>>> ACPI_EXCEPTION((AE_INFO, status,
>>> - "Thread %X could not acquire Mutex [%X]",
>>> - (u32) this_thread_id, mutex_id));
>>> + "Thread %p could not acquire Mutex [%X]",
>>> + this_thread_id, mutex_id));
>>> }
>>>
>>> return (status);
>>> Index: g26/drivers/acpi/tables/tbrsdt.c
>>> ===================================================================
>>> --- g26.orig/drivers/acpi/tables/tbrsdt.c 2006-07-14
>> 10:03:04.000000000 -0700
>>> +++ g26/drivers/acpi/tables/tbrsdt.c 2006-09-13 13:38:39.000000000 -
>> 0700
>>> @@ -187,7 +187,7 @@ acpi_status acpi_tb_validate_rsdt(struct
>>>
>>> if (table_ptr->length < sizeof(struct acpi_table_header)) {
>>> ACPI_ERROR((AE_INFO,
>>> - "RSDT/XSDT length (%X) is smaller than minimum
>> (%X)",
>>> + "RSDT/XSDT length (%X) is smaller than minimum
>> (%zX)",
>>> table_ptr->length,
>>> sizeof(struct acpi_table_header)));
>>>
>>> -
>>> To unsubscribe from this list: send the line "unsubscribe linux-kernel"
>> in
>>> the body of a message to majordomo@vger.kernel.org
>>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>> Please read the FAQ at http://www.tux.org/lkml/
>> --
>> Sérgio M.B.
> -
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
-
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2006-09-20 16:50 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-09-20 15:11 [Fwd: [patch 2.6.18-rc7] ACPI: build warnings begone (x86_64)] Moore, Robert
2006-09-20 15:49 ` David Brownell
2006-09-20 16:49 ` Alexey Starikovskiy
-- strict thread matches above, loose matches on Subject: below --
2006-09-20 15:55 Moore, Robert
2006-09-20 1:29 Sergio Monteiro Basto
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox