[Patch 0/3] ibm-acpi: Remove experimental flag from brightness and volume. Update documentation

[Patch 0/3] ibm-acpi: Remove experimental flag from brightness and volume. Update documentation

[Stefan Schmidt]

Hello Borislav.

Since version 0.11 ecdump, brightness, volume and fan a available in
ibm-acpi, but only if you set experimental=1 on loading.

You released this version at 2005-03-17. So this is quit some time to
see if some of these features make problems.

I think it's ok to make ecdump and fan only available, if loaded with
experimental. As ecdump is only for debugging and explore new features
and fan stop can damage the hardware.

Both features were tested with various scripts and application for a long 
time without problems.

Second patch updates the documentation for the first patch.

Third one documents the new wan feature from Jeremy Fitzhardinge. Please review
this, as I don't have a device to test this.

Please apply.

regards
Stefan Schmidt
--

-- 
The linux-thinkpad mailing list home page is at:
http://mailman.linux-thinkpad.org/mailman/listinfo/linux-thinkpad

[Patch 1/3] ibm-acpi: Get rid of experimental status for brightness and volume.

[Stefan Schmidt]

[-- Attachment #1: ibm-acpi-get-rid-of-experimental-status.patch --]
[-- Type: text/plain, Size: 847 bytes --]

The brightness and volume features from ibm-acpi are stable. The experimental
flag is no more needed.

Signed-off-by: Stefan Schmidt <stefan@datenfreihafen.org>
---
Index: linux-2.6.18-ibm-acpi/drivers/acpi/ibm_acpi.c
===================================================================
--- linux-2.6.18-ibm-acpi.orig/drivers/acpi/ibm_acpi.c	2006-09-21 21:02:41.000000000 +0200
+++ linux-2.6.18-ibm-acpi/drivers/acpi/ibm_acpi.c	2006-09-21 21:03:40.000000000 +0200
@@ -1702,13 +1702,11 @@
 	 .name = "brightness",
 	 .read = brightness_read,
 	 .write = brightness_write,
-	 .experimental = 1,
 	 },
 	{
 	 .name = "volume",
 	 .read = volume_read,
 	 .write = volume_write,
-	 .experimental = 1,
 	 },
 	{
 	 .name = "fan",

--

-- 
The linux-thinkpad mailing list home page is at:
http://mailman.linux-thinkpad.org/mailman/listinfo/linux-thinkpad

[Patch 2/3] ibm-acpi: Update documentation for brightness and volume.

[Stefan Schmidt]

[-- Attachment #1: ibm-acpi-get-rid-of-experimental-status-doc.patch --]
[-- Type: text/plain, Size: 2418 bytes --]

Document the change of the experimental flag for brightness and volume.

Signed-off-by: Stefan Schmidt <stefan@datenfreihafen.org>
---
Index: linux-2.6.18-ibm-acpi/Documentation/ibm-acpi.txt
===================================================================
--- linux-2.6.18-ibm-acpi.orig/Documentation/ibm-acpi.txt	2006-09-21 20:56:16.000000000 +0200
+++ linux-2.6.18-ibm-acpi/Documentation/ibm-acpi.txt	2006-09-21 20:59:22.000000000 +0200
@@ -30,8 +30,8 @@
 	- ACPI sounds
 	- temperature sensors
 	- Experimental: embedded controller register dump
-	- Experimental: LCD brightness control
-	- Experimental: volume control
+	- LCD brightness control
+	- Volume control
 	- Experimental: fan speed, fan enable/disable
 
 A compatibility table by model and feature is maintained on the web
@@ -523,13 +523,8 @@
 with this, do send me your results (including some complete dumps with
 a description of the conditions when they were taken.)
 
-EXPERIMENTAL: LCD brightness control -- /proc/acpi/ibm/brightness
------------------------------------------------------------------
-
-This feature is marked EXPERIMENTAL because the implementation
-directly accesses hardware registers and may not work as expected. USE
-WITH CAUTION! To use this feature, you need to supply the
-experimental=1 parameter when loading the module.
+LCD brightness control -- /proc/acpi/ibm/brightness
+---------------------------------------------------
 
 This feature allows software control of the LCD brightness on ThinkPad
 models which don't have a hardware brightness slider. The available
@@ -542,13 +537,8 @@
 The <level> number range is 0 to 7, although not all of them may be
 distinct. The current brightness level is shown in the file.
 
-EXPERIMENTAL: Volume control -- /proc/acpi/ibm/volume
------------------------------------------------------
-
-This feature is marked EXPERIMENTAL because the implementation
-directly accesses hardware registers and may not work as expected. USE
-WITH CAUTION! To use this feature, you need to supply the
-experimental=1 parameter when loading the module.
+Volume control -- /proc/acpi/ibm/volume
+---------------------------------------
 
 This feature allows volume control on ThinkPad models which don't have
 a hardware volume knob. The available commands are:

--

-- 
The linux-thinkpad mailing list home page is at:
http://mailman.linux-thinkpad.org/mailman/listinfo/linux-thinkpad

[Patch 3/3] ibm-acpi: Add documentation for wan feature.

[Stefan Schmidt]

[-- Attachment #1: ibm-acpi-update-doc-with-wan-feature.patch --]
[-- Type: text/plain, Size: 1691 bytes --]

Document the wan feature Jeremy Fitzhardinge added to ibm-acpi.

Signed-off-by: Stefan Schmidt <stefan@datenfreihafen.org>
---
Index: linux-2.6.18-ibm-acpi/Documentation/ibm-acpi.txt
===================================================================
--- linux-2.6.18-ibm-acpi.orig/Documentation/ibm-acpi.txt	2006-09-21 21:06:04.000000000 +0200
+++ linux-2.6.18-ibm-acpi/Documentation/ibm-acpi.txt	2006-09-21 21:20:52.000000000 +0200
@@ -33,6 +33,7 @@
 	- LCD brightness control
 	- Volume control
 	- Experimental: fan speed, fan enable/disable
+	- Experimental: WAN enable and disable
 
 A compatibility table by model and feature is maintained on the web
 site, http://ibm-acpi.sf.net/. I appreciate any success or failure
@@ -601,6 +602,23 @@
 
 	echo 'level <level>' > /proc/acpi/ibm/thermal
 
+EXPERIMENTAL: WAN -- /proc/acpi/ibm/wan
+---------------------------------------
+
+This feature is marked EXPERIMENTAL because the implementation
+directly accesses hardware registers and may not work as expected. USE
+WITH CAUTION! To use this feature, you need to supply the
+experimental=1 parameter when loading the module.
+
+This feature shows the presence and current state of a WAN (Sierra 
+Wireless EV-DO) device. If WAN is installed, the following commands can 
+be used:
+
+	echo enable > /proc/acpi/ibm/wan
+	echo disable > /proc/acpi/ibm/wan
+
+It was tested on a Lenovo Thinkpad X60. It should probably work on other
+Thinkpad models which come with this module installed.
 
 Multiple Commands, Module Parameters
 ------------------------------------

--

-- 
The linux-thinkpad mailing list home page is at:
http://mailman.linux-thinkpad.org/mailman/listinfo/linux-thinkpad

Re: [ltp] [Patch 0/3] ibm-acpi: Remove experimental flag from brightness and volume. Update documentation

[Stefan Schmidt]

Hello Len.

On Fri, 2006-09-22 at 12:19, Stefan Schmidt wrote:
> 
> Since version 0.11 ecdump, brightness, volume and fan a available in
> ibm-acpi, but only if you set experimental=1 on loading.
> 
> You released this version at 2005-03-17. So this is quit some time to
> see if some of these features make problems.
> 
> I think it's ok to make ecdump and fan only available, if loaded with
> experimental. As ecdump is only for debugging and explore new features
> and fan stop can damage the hardware.
> 
> Both features were tested with various scripts and application for a long 
> time without problems.
> 
> Second patch updates the documentation for the first patch.
> 
> Third one documents the new wan feature from Jeremy Fitzhardinge. Please review
> this, as I don't have a device to test this.

Any comments about this patches?

The first try of the first patch I sent to Borislav at 2006-08-24,
only linux-thinkpad cc'ed this time:

http://marc.theaimsgroup.com/?l=linux-thinkpad&m=115643103426795&w=2

Unfortunately it is not the first time Borislav don't reply on
patches. What's the way to go here?

regards
Stefan Schmidt

Re: [Patch 1/3] ibm-acpi: Get rid of experimental status for brightness and volume.

[Borislav Deianov]

On Fri, Sep 22, 2006 at 12:19:14PM +0200, Stefan Schmidt wrote:
> The brightness and volume features from ibm-acpi are stable. The experimental
> flag is no more needed.
> 
> Signed-off-by: Stefan Schmidt <stefan@datenfreihafen.org>

Looks good to me. Len, please apply.

Index: linux-2.6.18-ibm-acpi/drivers/acpi/ibm_acpi.c
===================================================================
--- linux-2.6.18-ibm-acpi.orig/drivers/acpi/ibm_acpi.c	2006-09-21 21:02:41.000000000 +0200
+++ linux-2.6.18-ibm-acpi/drivers/acpi/ibm_acpi.c	2006-09-21 21:03:40.000000000 +0200
@@ -1702,13 +1702,11 @@
 	 .name = "brightness",
 	 .read = brightness_read,
 	 .write = brightness_write,
-	 .experimental = 1,
 	 },
 	{
 	 .name = "volume",
 	 .read = volume_read,
 	 .write = volume_write,
-	 .experimental = 1,
 	 },
 	{
 	 .name = "fan",

Re: [Patch 2/3] ibm-acpi: Update documentation for brightness and volume.

[Borislav Deianov]

On Fri, Sep 22, 2006 at 12:19:15PM +0200, Stefan Schmidt wrote:
> Document the change of the experimental flag for brightness and volume.
> 
> Signed-off-by: Stefan Schmidt <stefan@datenfreihafen.org>

Looks good to me. Len, please apply.

Borislav


Index: linux-2.6.18-ibm-acpi/Documentation/ibm-acpi.txt
===================================================================
--- linux-2.6.18-ibm-acpi.orig/Documentation/ibm-acpi.txt	2006-09-21 20:56:16.000000000 +0200
+++ linux-2.6.18-ibm-acpi/Documentation/ibm-acpi.txt	2006-09-21 20:59:22.000000000 +0200
@@ -30,8 +30,8 @@
 	- ACPI sounds
 	- temperature sensors
 	- Experimental: embedded controller register dump
-	- Experimental: LCD brightness control
-	- Experimental: volume control
+	- LCD brightness control
+	- Volume control
 	- Experimental: fan speed, fan enable/disable
 
 A compatibility table by model and feature is maintained on the web
@@ -523,13 +523,8 @@
 with this, do send me your results (including some complete dumps with
 a description of the conditions when they were taken.)
 
-EXPERIMENTAL: LCD brightness control -- /proc/acpi/ibm/brightness
------------------------------------------------------------------
-
-This feature is marked EXPERIMENTAL because the implementation
-directly accesses hardware registers and may not work as expected. USE
-WITH CAUTION! To use this feature, you need to supply the
-experimental=1 parameter when loading the module.
+LCD brightness control -- /proc/acpi/ibm/brightness
+---------------------------------------------------
 
 This feature allows software control of the LCD brightness on ThinkPad
 models which don't have a hardware brightness slider. The available
@@ -542,13 +537,8 @@
 The <level> number range is 0 to 7, although not all of them may be
 distinct. The current brightness level is shown in the file.
 
-EXPERIMENTAL: Volume control -- /proc/acpi/ibm/volume
------------------------------------------------------
-
-This feature is marked EXPERIMENTAL because the implementation
-directly accesses hardware registers and may not work as expected. USE
-WITH CAUTION! To use this feature, you need to supply the
-experimental=1 parameter when loading the module.
+Volume control -- /proc/acpi/ibm/volume
+---------------------------------------
 
 This feature allows volume control on ThinkPad models which don't have
 a hardware volume knob. The available commands are:

Re: [Patch 3/3] ibm-acpi: Add documentation for wan feature.

[Borislav Deianov]

On Fri, Sep 22, 2006 at 12:19:16PM +0200, Stefan Schmidt wrote:
> Document the wan feature Jeremy Fitzhardinge added to ibm-acpi.
> 
> Signed-off-by: Stefan Schmidt <stefan@datenfreihafen.org>

Looks good to me. Len, please apply.

Borislav

Index: linux-2.6.18-ibm-acpi/Documentation/ibm-acpi.txt
===================================================================
--- linux-2.6.18-ibm-acpi.orig/Documentation/ibm-acpi.txt	2006-09-21 21:06:04.000000000 +0200
+++ linux-2.6.18-ibm-acpi/Documentation/ibm-acpi.txt	2006-09-21 21:20:52.000000000 +0200
@@ -33,6 +33,7 @@
 	- LCD brightness control
 	- Volume control
 	- Experimental: fan speed, fan enable/disable
+	- Experimental: WAN enable and disable
 
 A compatibility table by model and feature is maintained on the web
 site, http://ibm-acpi.sf.net/. I appreciate any success or failure
@@ -601,6 +602,23 @@
 
 	echo 'level <level>' > /proc/acpi/ibm/thermal
 
+EXPERIMENTAL: WAN -- /proc/acpi/ibm/wan
+---------------------------------------
+
+This feature is marked EXPERIMENTAL because the implementation
+directly accesses hardware registers and may not work as expected. USE
+WITH CAUTION! To use this feature, you need to supply the
+experimental=1 parameter when loading the module.
+
+This feature shows the presence and current state of a WAN (Sierra 
+Wireless EV-DO) device. If WAN is installed, the following commands can 
+be used:
+
+	echo enable > /proc/acpi/ibm/wan
+	echo disable > /proc/acpi/ibm/wan
+
+It was tested on a Lenovo Thinkpad X60. It should probably work on other
+Thinkpad models which come with this module installed.
 
 Multiple Commands, Module Parameters
 ------------------------------------

Re: [Patch 0/3] ibm-acpi: Remove experimental flag from brightness and volume. Update documentation

[Len Brown]

I've applied 1-3.

Note, however, that the long-term direction is to make these features
available under generic sysfs interfaces, rather than  under /proc/acpi.

thanks,
-Len