public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Len Brown <len.brown@intel.com>
To: Dave Jones <davej@redhat.com>, Jeff Garzik <jeff@garzik.org>
Cc: linux-acpi@vger.kernel.org,
	Linux-pm mailing list <linux-pm@lists.osdl.org>
Subject: T30 boot hang with CONFIG_PM_LEGACY=n
Date: Wed, 27 Sep 2006 00:00:40 -0400	[thread overview]
Message-ID: <200609270000.40760.len.brown@intel.com> (raw)
In-Reply-To: <20060927024628.GA29182@redhat.com>

My T30 doesn't boot if CONFIG_PM_LEGACY=n
unless "apm=off".

Seems that this build option causes PM_IS_ACTIVE() to be constant 0,
which disables APM's check to see if ACPI is running:

apm_init()
	...
        if (PM_IS_ACTIVE()) {
                printk(KERN_NOTICE "apm: overridden by ACPI.\n");
                apm_info.disabled = 1;
                return -ENODEV;
        }

Apparently when CONFIG_PM_LEGACY was created, CONFIG_APM depended
on it, so apm.c wasn't built.  But that dependency was later removed so it is now possible
to build APM with its check for ACPI  mysteriously disabled -- much to the unhappyness
of my T30.

What's the plan here?  Perhaps that plan should be written down
in kernel/power/Kconfig? 

config PM_LEGACY
        bool "Legacy Power Management API"
        depends on PM
        default y
        ---help---
           Support for pm_register() and friends.

           If unsure, say Y.

thanks,
-Len

       reply	other threads:[~2006-09-27  3:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20060927024628.GA29182@redhat.com>
2006-09-27  4:00 ` Len Brown [this message]
2006-09-27  4:20   ` T30 boot hang with CONFIG_PM_LEGACY=n Dave Jones
2006-09-27 14:47     ` Matthew Garrett
2006-09-27 17:15       ` Dave Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200609270000.40760.len.brown@intel.com \
    --to=len.brown@intel.com \
    --cc=davej@redhat.com \
    --cc=jeff@garzik.org \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-pm@lists.osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox