From: Andrew Morton <akpm@osdl.org>
To: Martin Bligh <mbligh@google.com>
Cc: LKML <linux-kernel@vger.kernel.org>, linux-acpi@vger.kernel.org
Subject: Re: [PATCH] Fix up a multitude of ACPI compiler warnings on x86_64
Date: Fri, 29 Sep 2006 15:05:26 -0700 [thread overview]
Message-ID: <20060929150526.38eec941.akpm@osdl.org> (raw)
In-Reply-To: <451D9236.6040902@google.com>
On Fri, 29 Sep 2006 14:37:58 -0700
Martin Bligh <mbligh@google.com> wrote:
> 32bit vs 64 bit issues. sizeof(sizeof) and sizeof(pointer) is variable,
> but we're trying to shove it into unsigned int or u32.
>
> ...
>
> - "RSDT/XSDT length (%X) is smaller than minimum (%X)",
> + "RSDT/XSDT length (%X) is smaller than minimum (%lX)",
> table_ptr->length,
> - sizeof(struct acpi_table_header)));
> + (unsigned long) sizeof(struct acpi_table_header)));
>
These two sizeof()s have already been fixed by Randy in -mm's
acpi-fix-printk-format-warnings.patch.
Randy's fix is the preferred one: sizeof() returns size_t and size_t's are
printed with %z - there's no need to use a typecast.
(Actually Randy used %Z which avoids the warning which old gcc emitted with
%z, but is old-fashioned. I'll switch that to %z).
acpi-fix-printk-format-warnings.patch was submitted to the ACPI developers
on August 14 and on September 25 but remains unmerged.
next prev parent reply other threads:[~2006-09-29 22:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-29 21:37 [PATCH] Fix up a multitude of ACPI compiler warnings on x86_64 Martin Bligh
2006-09-29 22:05 ` Andrew Morton [this message]
2006-09-29 23:18 ` Randy Dunlap
2006-09-29 23:38 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060929150526.38eec941.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mbligh@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox