From: Holger Macht <hmacht@suse.de>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
len.brown@intel.com
Subject: Re: [PATCH] Add support for the generic backlight device to the IBM ACPI driver
Date: Fri, 13 Oct 2006 12:25:50 +0200 [thread overview]
Message-ID: <20061013102550.GE4234@homac.suse.de> (raw)
In-Reply-To: <20061011201027.a4be98c4.akpm@osdl.org>
On Wed 11. Oct - 20:10:27, Andrew Morton wrote:
> On Mon, 9 Oct 2006 13:32:35 +0200
> Holger Macht <hmacht@suse.de> wrote:
>
> > @@ -200,6 +200,7 @@ config ACPI_ASUS
> > config ACPI_IBM
> > tristate "IBM ThinkPad Laptop Extras"
> > depends on X86
> > + select BACKLIGHT
>
> drivers/acpi/Kconfig:210:warning: 'select' used by config symbol 'ACPI_IBM' refer to undefined symbol 'BACKLIGHT'
>
> select really sucks :(
Of course it has to be BACKLIGHT_DEVICE. I've sent an updated version of
the patch together with the adjustments of the asus_acpi and toshiba_acpi
drivers.
Regards,
Holger
prev parent reply other threads:[~2006-10-13 10:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-09 11:32 [PATCH] Add support for the generic backlight device to the IBM ACPI driver Holger Macht
2006-10-11 11:30 ` Pavel Machek
2006-10-11 12:54 ` Richard Hughes
2006-10-11 12:59 ` Arjan van de Ven
2006-10-12 3:10 ` Andrew Morton
2006-10-13 10:25 ` Holger Macht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061013102550.GE4234@homac.suse.de \
--to=hmacht@suse.de \
--cc=akpm@osdl.org \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox