From: Andrew Morton <akpm@osdl.org>
To: Holger Macht <hmacht@suse.de>
Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
len.brown@intel.com
Subject: Re: [PATCH 3/3] Add support for the generic backlight device to the TOSHIBA ACPI driver
Date: Fri, 13 Oct 2006 14:56:58 -0700 [thread overview]
Message-ID: <20061013145658.99de9f54.akpm@osdl.org> (raw)
In-Reply-To: <20061013102419.GD4234@homac.suse.de>
On Fri, 13 Oct 2006 12:24:19 +0200
Holger Macht <hmacht@suse.de> wrote:
> +static int set_lcd(int value)
> +{
> + u32 hci_result;
> +
> + value = value << HCI_LCD_BRIGHTNESS_SHIFT;
> + hci_write1(HCI_LCD_BRIGHTNESS, value, &hci_result);
> + if (hci_result != HCI_SUCCESS)
> + return -EFAULT;
> +
> + return 0;
-EFAULT seems a bit random. Would -EIO be more appropriate?
prev parent reply other threads:[~2006-10-13 21:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-13 10:24 [PATCH 3/3] Add support for the generic backlight device to the TOSHIBA ACPI driver Holger Macht
2006-10-13 21:56 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061013145658.99de9f54.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=hmacht@suse.de \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox