From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andi Kleen Subject: Re: 2.6.19-rc <-> ThinkPads Date: Wed, 1 Nov 2006 22:15:51 +0100 Message-ID: <200611012215.51459.ak@suse.de> References: <200611012034.06128.ak@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-pm-bounces@lists.osdl.org Errors-To: linux-pm-bounces@lists.osdl.org To: Linus Torvalds Cc: Andrew Morton , linux-pm@osdl.org, Ernst Herzberg , Linux Kernel Mailing List , Adrian Bunk , linux-acpi@vger.kernel.org, "Michael S. Tsirkin" , Hugh Dickins , Martin Lorenz List-Id: linux-acpi@vger.kernel.org On Wednesday 01 November 2006 20:52, Linus Torvalds wrote: > = > On Wed, 1 Nov 2006, Andi Kleen wrote: > > = > > Fix race in IO-APIC routing entry setup. > > = > > Interrupt could happen between setting the IO-APIC entry > > and setting its interrupt data. > = > This doesn't fix anything at all. > = > The interrupt can come in on another CPU, = Only BP should be active at this point. At least not until we implement IO-APIC hotplug, but so far that isn't there. Ok in theory the BIOS could have put the other CPUs into weird states where they are still doing something and causing interrupts, but that would be a BIOS bug. I suppose it could happen with kexec, but that has still other problems anyways. The common case of no kexec shouldn't be affected at least. -Andi