From: Corentin CHARY <corentincj@iksaif.net>
To: linux-acpi@vger.kernel.org
Subject: [Patch] Default values for asus_acpi
Date: Sun, 12 Nov 2006 14:22:28 +0100 [thread overview]
Message-ID: <200611121422.29019.corentincj@iksaif.net> (raw)
With the current default values, unsuported laptops usualy get a lot of "Asus
ACPI: Error reading LCD status" in dmesg. And it's also a problem for apps
like kmilo : http://bugs.kde.org/show_bug.cgi?id=102374 .
So, I think default values should be changed..
For example :
--- linux-2.6.19-rc5/drivers/acpi/asus_acpi.c 2006-11-08 03:24:20.000000000
+0100
+++ asus_acpi.c 2006-11-12 14:10:03.000000000 +0100
@@ -141,6 +141,7 @@
W3V, //W3030V
xxN, //M2400N, M3700N, M5200N, M6800N, S1300N, S5200N
//(Centrino)
+ DEF, //Others ...
END_MODEL
} model; //Models currently supported
u16 event_count[128]; //count for each event TODO make this better
@@ -396,7 +397,19 @@
.brightness_set = "SPLV",
.brightness_get = "GPLV",
.display_set = "SDSP",
- .display_get = "\\ADVG"}
+ .display_get = "\\ADVG"},
+
+ {
+ .name = "???",
+ .mt_mled = "MLED",
+ .mt_wled = "WLED",
+ /* lcd_switch not supported as lcd_status is needed,
+ but never the same */
+ .brightness_set = "SPLV",
+ .brightness_get = "GPLV",
+ .display_set = "SDSP",
+ .display_get = "\\INFB"}, /* Most of the time, it's \\INFB */
+
};
/* procdir we use */
@@ -1177,7 +1190,7 @@
printk(KERN_NOTICE
" Samsung P30 detected, supported\n");
} else {
- hotk->model = M2E;
+ hotk->model = DEF;
printk(KERN_NOTICE " unsupported model %s, trying "
"default values\n", string);
printk(KERN_NOTICE
--
CHARY 'Iksaif' Corentin
corentincj@iksaif.net - corentincj@yahoo.fr
http://xf.iksaif.net
next reply other threads:[~2006-11-12 13:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-12 13:22 Corentin CHARY [this message]
2006-11-27 16:39 ` [Patch] Default values for asus_acpi Thomas Renninger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200611121422.29019.corentincj@iksaif.net \
--to=corentincj@iksaif.net \
--cc=linux-acpi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox