public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: David Brownell <david-b@pacbell.net>
To: Alexey Starikovskiy <alexey.y.starikovskiy@linux.intel.com>
Cc: Len Brown <lenb@kernel.org>,
	Linux Kernel list <linux-kernel@vger.kernel.org>,
	linux-acpi@vger.kernel.org
Subject: Re: 2.6.19-rc5 nasty ACPI regression, AE_TIME errors
Date: Wed, 15 Nov 2006 13:56:52 -0800	[thread overview]
Message-ID: <200611151356.52985.david-b@pacbell.net> (raw)
In-Reply-To: <455B28B2.4010707@linux.intel.com>

On Wednesday 15 November 2006 6:48 am, Alexey Starikovskiy wrote:
> ec1.patch
> 
> 
> Always enable GPE after return from notify handler.
> 
> From:  Alexey Starikovskiy <alexey.y.starikovskiy@linux.intel.com>
> 
> 
> ---

Yes, this seems to resolve the regression as well as Len's ec_intr=0 boot param.

IMO this should get merged into 2.6.19 ASAP ...


>  drivers/acpi/ec.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c
> index e6d4b08..937eafc 100644
> --- a/drivers/acpi/ec.c
> +++ b/drivers/acpi/ec.c
> @@ -465,8 +465,6 @@ static u32 acpi_ec_gpe_handler(void *dat
>  
>         if (value & ACPI_EC_FLAG_SCI) {
>                 status = acpi_os_execute(OSL_EC_BURST_HANDLER, acpi_ec_gpe_query, ec);
> -               return status == AE_OK ?
> -                   ACPI_INTERRUPT_HANDLED : ACPI_INTERRUPT_NOT_HANDLED;
>         }
>         acpi_enable_gpe(NULL, ec->gpe_bit, ACPI_ISR);
>         return status == AE_OK ?
-
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2006-11-15 23:45 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200611142303.47325.david-b@pacbell.net>
2006-11-15  7:48 ` 2.6.19-rc5 nasty ACPI regression, AE_TIME errors Len Brown
2006-11-15 14:48   ` Alexey Starikovskiy
2006-11-15 21:56     ` David Brownell [this message]
2006-11-16  1:10       ` David Brownell
2006-11-16 15:41         ` Alexey Starikovskiy
2006-11-16 16:03           ` David Brownell
2006-11-16 16:23             ` Alexey Starikovskiy
2006-11-16 16:53               ` David Brownell
2006-11-16 21:56                 ` Alexey Starikovskiy
2006-11-17 21:45                   ` [Bulk] " David Brownell
2006-11-17  6:22           ` David Brownell
2006-11-17 21:04             ` David Brownell
2006-11-18 16:18               ` Alexey Starikovskiy
2006-11-15 18:46   ` David Brownell
2006-11-21 14:47   ` Janosch Machowinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200611151356.52985.david-b@pacbell.net \
    --to=david-b@pacbell.net \
    --cc=alexey.y.starikovskiy@linux.intel.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox