Re: 2.6.19-rc5 nasty ACPI regression, AE_TIME errors

David Brownell
2006-11-17T06:22:48Z

On Thursday 16 November 2006 7:41 am, Alexey Starikovskiy wrote:
> --- a/drivers/acpi/ec.c
> +++ b/drivers/acpi/ec.c
> @@ -467,8 +467,8 @@ static u32 acpi_ec_gpe_handler(void *dat
>                 status = acpi_os_execute(OSL_EC_BURST_HANDLER, acpi_ec_gpe_query, ec);
>         }
>         acpi_enable_gpe(NULL, ec->gpe_bit, ACPI_ISR);
> -       return status == AE_OK ?
> -           ACPI_INTERRUPT_HANDLED : ACPI_INTERRUPT_NOT_HANDLED;
> +       WARN_ON(ACPI_FAILURE(status));
> +       return ACPI_INTERRUPT_HANDLED;
>  }
>

Strange ... applying this on top of the previous patch seems to work
much better, but that WARN_ON hasn't triggered. At least, not yet.
Updating to RC6, with your two patches installed...

- Dave
-
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html