public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Len Brown <lenb@kernel.org>
To: akpm@osdl.org
Cc: linux-acpi@vger.kernel.org, bunk@stusta.de
Subject: Re: [patch 06/19] drivers/acpi/osl.c: fix a NULL check
Date: Wed, 20 Dec 2006 01:30:02 -0500	[thread overview]
Message-ID: <200612200130.02294.lenb@kernel.org> (raw)
In-Reply-To: <200612192056.kBJKuDdQ010023@shell0.pdx.osdl.net>

Applied.

(note the comment was incorrect this was introduced long before that commit).

Thanks Coverity, Adrian,
-Len

On Tuesday 19 December 2006 15:56, akpm@osdl.org wrote:
> From: Adrian Bunk <bunk@stusta.de>
> 
> This patch fixes a non-working NULL check introduced by commit
> b229cf92eee616c7cb5ad8cdb35a19b119f00bc8.
> 
> Spotted by the Coverity checker.
> 
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
> Signed-off-by: Andrew Morton <akpm@osdl.org>
> ---
> 
>  drivers/acpi/osl.c |    2 +-
>  1 files changed, 1 insertion(+), 1 deletion(-)
> 
> diff -puN drivers/acpi/osl.c~drivers-acpi-oslc-fix-a-null-check drivers/acpi/osl.c
> --- a/drivers/acpi/osl.c~drivers-acpi-oslc-fix-a-null-check
> +++ a/drivers/acpi/osl.c
> @@ -1032,7 +1032,7 @@ acpi_status
>  acpi_os_create_cache(char *name, u16 size, u16 depth, acpi_cache_t ** cache)
>  {
>  	*cache = kmem_cache_create(name, size, 0, 0, NULL, NULL);
> -	if (cache == NULL)
> +	if (*cache == NULL)
>  		return AE_ERROR;
>  	else
>  		return AE_OK;
> _
> 

  reply	other threads:[~2006-12-20  6:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-19 20:56 [patch 06/19] drivers/acpi/osl.c: fix a NULL check akpm
2006-12-20  6:30 ` Len Brown [this message]
2006-12-22  8:17   ` Adrian Bunk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200612200130.02294.lenb@kernel.org \
    --to=lenb@kernel.org \
    --cc=akpm@osdl.org \
    --cc=bunk@stusta.de \
    --cc=linux-acpi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox