* [PATCH 2/22] Remove trailing whitespace
@ 2006-12-19 21:18 Corentin CHARY
2006-12-20 7:35 ` Len Brown
0 siblings, 1 reply; 4+ messages in thread
From: Corentin CHARY @ 2006-12-19 21:18 UTC (permalink / raw)
To: len.brown; +Cc: linux-acpi
Remove some trailing whitespace.
Signed-off-by: Corentin Chary <corentincj@iksaif.net>
---
asus_acpi.c | 46 +++++++++++++++++++++++-----------------------
1 file changed, 23 insertions(+), 23 deletions(-)
--- a/drivers/acpi/asus_acpi.c 2006-12-15 10:35:29.000000000 +0100
+++ b/drivers/acpi/asus_acpi.c 2006-12-15 10:30:52.000000000 +0100
@@ -83,7 +83,7 @@
module_param(asus_gid, uint, 0);
MODULE_PARM_DESC(asus_gid, "GID for entries in /proc/acpi/asus.\n");
-/* For each model, all features implemented,
+/* For each model, all features implemented,
* those marked with R are relative to HOTK, A for absolute */
struct model_data {
char *name; //name of the laptop________________A
@@ -128,7 +128,7 @@
L3D, //L3400D
L3H, //L3H, L2000E, L5D
L4R, //L4500R
- L5x, //L5800C
+ L5x, //L5800C
L8L, //L8400L
M1A, //M1300A
M2E, //M2400E, L4400L
@@ -428,12 +428,12 @@
},
};
-/*
+/*
* This function evaluates an ACPI method, given an int as parameter, the
* method is searched within the scope of the handle, can be NULL. The output
* of the method is written is output, which can also be NULL
*
- * returns 1 if write is successful, 0 else.
+ * returns 1 if write is successful, 0 else.
*/
static int write_acpi_int(acpi_handle handle, const char *method, int val,
struct acpi_buffer *output)
@@ -485,9 +485,9 @@
len += sprintf(page, ACPI_HOTK_NAME " " ASUS_ACPI_VERSION "\n");
len += sprintf(page + len, "Model reference : %s\n",
hotk->methods->name);
- /*
- * The SFUN method probably allows the original driver to get the list
- * of features supported by a given model. For now, 0x0100 or 0x0800
+ /*
+ * The SFUN method probably allows the original driver to get the list
+ * of features supported by a given model. For now, 0x0100 or 0x0800
* bit signifies that the laptop is equipped with a Wi-Fi MiniPCI
card.
* The significance of others is yet to be found.
*/
@@ -497,7 +497,7 @@
/*
* Another value for userspace: the ASYM method returns 0x02 for
* battery low and 0x04 for battery critical, its readings tend to be
- * more accurate than those provided by _BST.
+ * more accurate than those provided by _BST.
* Note: since not all the laptops provide this method, errors are
* silently ignored.
*/
@@ -666,7 +666,7 @@
proc_write_bluetooth(struct file *file, const char __user * buffer,
unsigned long count, void *data)
{
- /* Note: mt_bt_switch controls both internal Bluetooth adapter's
+ /* Note: mt_bt_switch controls both internal Bluetooth adapter's
presence and its LED */
return write_led(buffer, count, hotk->methods->mt_bt_switch, BT_ON,
0);
}
@@ -710,7 +710,7 @@
input.count = 2;
input.pointer = mt_params;
- /* Note: the following values are partly guessed up, but
+ /* Note: the following values are partly guessed up, but
otherwise they seem to work */
mt_params[0].type = ACPI_TYPE_INTEGER;
mt_params[0].integer.value = 0x02;
@@ -751,7 +751,7 @@
(hotk->handle, hotk->methods->mt_lcd_switch, 0x07,
NULL))
status = AE_ERROR;
- /* L3H's AML executes EHK (0x07) upon Fn+F7 keypress,
+ /* L3H's AML executes EHK (0x07) upon Fn+F7 keypress,
the exact behaviour is simulated here */
}
if (ACPI_FAILURE(status))
@@ -862,7 +862,7 @@
}
/*
- * Now, *this* one could be more user-friendly, but so far, no-one has
+ * Now, *this* one could be more user-friendly, but so far, no-one has
* complained. The significance of bits is the same as in proc_write_disp()
*/
static int
@@ -879,9 +879,9 @@
}
/*
- * Experimental support for display switching. As of now: 1 should activate
- * the LCD output, 2 should do for CRT, and 4 for TV-Out. Any combination
- * (bitwise) of these will suffice. I never actually tested 3 displays hooked
up
+ * Experimental support for display switching. As of now: 1 should activate
+ * the LCD output, 2 should do for CRT, and 4 for TV-Out. Any combination
+ * (bitwise) of these will suffice. I never actually tested 3 displays hooked
up
* simultaneously, so be warned. See the acpi4asus README for more info.
*/
static int
@@ -981,9 +981,9 @@
&proc_read_bluetooth, mode, device);
}
- /*
- * We need both read node and write method as LCD switch is also
accessible
- * from keyboard
+ /*
+ * We need both read node and write method as LCD switch is also
+ * accessible from keyboard
*/
if (hotk->methods->mt_lcd_switch && hotk->methods->lcd_status) {
asus_proc_add(PROC_LCD, &proc_write_lcd, &proc_read_lcd, mode,
@@ -1124,8 +1124,8 @@
acpi_status status;
/*
- * Get DSDT headers early enough to allow for differentiating between
- * models, but late enough to allow acpi_bus_register_driver() to fail
+ * Get DSDT headers early enough to allow for differentiating between
+ * models, but late enough to allow acpi_bus_register_driver() to fail
* before doing anything ACPI-specific. Should we encounter a machine,
* which needs special handling (i.e. its hotkey device has a
different
* HID), this bit will be moved. A global variable asus_info contains
@@ -1152,8 +1152,8 @@
/*
* Try to match the object returned by INIT to the specific model.
- * Handle every possible object (or the lack of thereof) the DSDT
- * writers might throw at us. When in trouble, we pass NULL to
+ * Handle every possible object (or the lack of thereof) the DSDT
+ * writers might throw at us. When in trouble, we pass NULL to
* asus_model_match() and try something completely different.
*/
if (buffer.pointer) {
@@ -1193,7 +1193,7 @@
/* Sort of per-model blacklist */
if (strncmp(string, "L2B", 3) == 0)
hotk->methods->lcd_status = NULL;
- /* L2B is similar enough to L3C to use its settings, with this only
+ /* L2B is similar enough to L3C to use its settings, with this only
exception */
else if (strncmp(string, "A3G", 3) == 0)
hotk->methods->lcd_status = "\\BLFG";
--
CHARY 'Iksaif' Corentin
http://xf.iksaif.net
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2/22] Remove trailing whitespace
2006-12-19 21:18 [PATCH 2/22] Remove trailing whitespace Corentin CHARY
@ 2006-12-20 7:35 ` Len Brown
2006-12-20 8:40 ` Corentin CHARY
0 siblings, 1 reply; 4+ messages in thread
From: Len Brown @ 2006-12-20 7:35 UTC (permalink / raw)
To: corentincj; +Cc: linux-acpi
On Tuesday 19 December 2006 16:18, Corentin CHARY wrote:
> @@ -485,9 +485,9 @@
> len += sprintf(page, ACPI_HOTK_NAME " " ASUS_ACPI_VERSION "\n");
> len += sprintf(page + len, "Model reference : %s\n",
> hotk->methods->name);
> - /*
> - * The SFUN method probably allows the original driver to get the list
> - * of features supported by a given model. For now, 0x0100 or 0x0800
> + /*
> + * The SFUN method probably allows the original driver to get the list
> + * of features supported by a given model. For now, 0x0100 or 0x0800
> * bit signifies that the laptop is equipped with a Wi-Fi MiniPCI
> card.
This patch is corrupt because "card." starts a new line.
If you are using kmail, perhaps you could check
settings/configure kmail/composer/
and uncheck "word wrap at column [n]"
thanks,
-Len
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2/22] Remove trailing whitespace
2006-12-20 7:35 ` Len Brown
@ 2006-12-20 8:40 ` Corentin CHARY
2006-12-23 2:06 ` Len Brown
0 siblings, 1 reply; 4+ messages in thread
From: Corentin CHARY @ 2006-12-20 8:40 UTC (permalink / raw)
To: Len Brown; +Cc: linux-acpi
Yep, I use kmail ... Here is the patch without corruptions.
Also available here :
http://xf.iksaif.net/acpi4asus/2.6.19/0001-asus_acpi-remove-trailing-whitespace.patch .
--- a/drivers/acpi/asus_acpi.c 2006-12-15 10:35:29.000000000 +0100
+++ b/drivers/acpi/asus_acpi.c 2006-12-15 10:30:52.000000000 +0100
@@ -83,7 +83,7 @@
module_param(asus_gid, uint, 0);
MODULE_PARM_DESC(asus_gid, "GID for entries in /proc/acpi/asus.\n");
-/* For each model, all features implemented,
+/* For each model, all features implemented,
* those marked with R are relative to HOTK, A for absolute */
struct model_data {
char *name; //name of the laptop________________A
@@ -128,7 +128,7 @@
L3D, //L3400D
L3H, //L3H, L2000E, L5D
L4R, //L4500R
- L5x, //L5800C
+ L5x, //L5800C
L8L, //L8400L
M1A, //M1300A
M2E, //M2400E, L4400L
@@ -428,12 +428,12 @@
},
};
-/*
+/*
* This function evaluates an ACPI method, given an int as parameter, the
* method is searched within the scope of the handle, can be NULL. The output
* of the method is written is output, which can also be NULL
*
- * returns 1 if write is successful, 0 else.
+ * returns 1 if write is successful, 0 else.
*/
static int write_acpi_int(acpi_handle handle, const char *method, int val,
struct acpi_buffer *output)
@@ -485,9 +485,9 @@
len += sprintf(page, ACPI_HOTK_NAME " " ASUS_ACPI_VERSION "\n");
len += sprintf(page + len, "Model reference : %s\n",
hotk->methods->name);
- /*
- * The SFUN method probably allows the original driver to get the list
- * of features supported by a given model. For now, 0x0100 or 0x0800
+ /*
+ * The SFUN method probably allows the original driver to get the list
+ * of features supported by a given model. For now, 0x0100 or 0x0800
* bit signifies that the laptop is equipped with a Wi-Fi MiniPCI card.
* The significance of others is yet to be found.
*/
@@ -497,7 +497,7 @@
/*
* Another value for userspace: the ASYM method returns 0x02 for
* battery low and 0x04 for battery critical, its readings tend to be
- * more accurate than those provided by _BST.
+ * more accurate than those provided by _BST.
* Note: since not all the laptops provide this method, errors are
* silently ignored.
*/
@@ -666,7 +666,7 @@
proc_write_bluetooth(struct file *file, const char __user * buffer,
unsigned long count, void *data)
{
- /* Note: mt_bt_switch controls both internal Bluetooth adapter's
+ /* Note: mt_bt_switch controls both internal Bluetooth adapter's
presence and its LED */
return write_led(buffer, count, hotk->methods->mt_bt_switch, BT_ON, 0);
}
@@ -710,7 +710,7 @@
input.count = 2;
input.pointer = mt_params;
- /* Note: the following values are partly guessed up, but
+ /* Note: the following values are partly guessed up, but
otherwise they seem to work */
mt_params[0].type = ACPI_TYPE_INTEGER;
mt_params[0].integer.value = 0x02;
@@ -751,7 +751,7 @@
(hotk->handle, hotk->methods->mt_lcd_switch, 0x07,
NULL))
status = AE_ERROR;
- /* L3H's AML executes EHK (0x07) upon Fn+F7 keypress,
+ /* L3H's AML executes EHK (0x07) upon Fn+F7 keypress,
the exact behaviour is simulated here */
}
if (ACPI_FAILURE(status))
@@ -862,7 +862,7 @@
}
/*
- * Now, *this* one could be more user-friendly, but so far, no-one has
+ * Now, *this* one could be more user-friendly, but so far, no-one has
* complained. The significance of bits is the same as in proc_write_disp()
*/
static int
@@ -879,9 +879,9 @@
}
/*
- * Experimental support for display switching. As of now: 1 should activate
- * the LCD output, 2 should do for CRT, and 4 for TV-Out. Any combination
- * (bitwise) of these will suffice. I never actually tested 3 displays hooked up
+ * Experimental support for display switching. As of now: 1 should activate
+ * the LCD output, 2 should do for CRT, and 4 for TV-Out. Any combination
+ * (bitwise) of these will suffice. I never actually tested 3 displays hooked up
* simultaneously, so be warned. See the acpi4asus README for more info.
*/
static int
@@ -981,9 +981,9 @@
&proc_read_bluetooth, mode, device);
}
- /*
- * We need both read node and write method as LCD switch is also accessible
- * from keyboard
+ /*
+ * We need both read node and write method as LCD switch is also
+ * accessible from keyboard
*/
if (hotk->methods->mt_lcd_switch && hotk->methods->lcd_status) {
asus_proc_add(PROC_LCD, &proc_write_lcd, &proc_read_lcd, mode,
@@ -1124,8 +1124,8 @@
acpi_status status;
/*
- * Get DSDT headers early enough to allow for differentiating between
- * models, but late enough to allow acpi_bus_register_driver() to fail
+ * Get DSDT headers early enough to allow for differentiating between
+ * models, but late enough to allow acpi_bus_register_driver() to fail
* before doing anything ACPI-specific. Should we encounter a machine,
* which needs special handling (i.e. its hotkey device has a different
* HID), this bit will be moved. A global variable asus_info contains
@@ -1152,8 +1152,8 @@
/*
* Try to match the object returned by INIT to the specific model.
- * Handle every possible object (or the lack of thereof) the DSDT
- * writers might throw at us. When in trouble, we pass NULL to
+ * Handle every possible object (or the lack of thereof) the DSDT
+ * writers might throw at us. When in trouble, we pass NULL to
* asus_model_match() and try something completely different.
*/
if (buffer.pointer) {
@@ -1193,7 +1193,7 @@
/* Sort of per-model blacklist */
if (strncmp(string, "L2B", 3) == 0)
hotk->methods->lcd_status = NULL;
- /* L2B is similar enough to L3C to use its settings, with this only
+ /* L2B is similar enough to L3C to use its settings, with this only
exception */
else if (strncmp(string, "A3G", 3) == 0)
hotk->methods->lcd_status = "\\BLFG";
Le mercredi 20 décembre 2006 08:35, Len Brown a écrit :
> On Tuesday 19 December 2006 16:18, Corentin CHARY wrote:
> > @@ -485,9 +485,9 @@
> > len += sprintf(page, ACPI_HOTK_NAME " " ASUS_ACPI_VERSION "\n");
> > len += sprintf(page + len, "Model reference : %s\n",
> > hotk->methods->name);
> > - /*
> > - * The SFUN method probably allows the original driver to get the
> > list - * of features supported by a given model. For now, 0x0100
> > or 0x0800 + /*
> > + * The SFUN method probably allows the original driver to get the
> > list + * of features supported by a given model. For now, 0x0100
> > or 0x0800 * bit signifies that the laptop is equipped with a Wi-Fi
> > MiniPCI card.
>
> This patch is corrupt because "card." starts a new line.
> If you are using kmail, perhaps you could check
> settings/configure kmail/composer/
> and uncheck "word wrap at column [n]"
>
> thanks,
> -Len
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
CHARY 'Iksaif' Corentin
http://xf.iksaif.net
-
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2/22] Remove trailing whitespace
2006-12-20 8:40 ` Corentin CHARY
@ 2006-12-23 2:06 ` Len Brown
0 siblings, 0 replies; 4+ messages in thread
From: Len Brown @ 2006-12-23 2:06 UTC (permalink / raw)
To: corentincj; +Cc: linux-acpi
On Wednesday 20 December 2006 03:40, Corentin CHARY wrote:
> Yep, I use kmail ... Here is the patch without corruptions.
> Also available here :
> http://xf.iksaif.net/acpi4asus/2.6.19/0001-asus_acpi-remove-trailing-whitespace.patch .
The entire series is corrupt, please re-send the whole series -- not just this patch.
thanks,
-Len
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2006-12-23 2:07 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-12-19 21:18 [PATCH 2/22] Remove trailing whitespace Corentin CHARY
2006-12-20 7:35 ` Len Brown
2006-12-20 8:40 ` Corentin CHARY
2006-12-23 2:06 ` Len Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox