From: Bjorn Helgaas <bjorn.helgaas@hp.com>
To: Matthew Brett <matthew.brett@gmail.com>
Cc: linux-acpi@vger.kernel.org, konstantin.a.karasyov@intel.com
Subject: Re: PROBLEM: CPU fan shuts down on load of fan.ko in kernel 2.6.18 and later
Date: Sun, 7 Jan 2007 22:08:07 -0700 [thread overview]
Message-ID: <200701072208.07831.bjorn.helgaas@hp.com> (raw)
In-Reply-To: <1e2af89e0701071210i3efc9f50w635013f7ec0b0a32@mail.gmail.com>
On Sunday 07 January 2007 13:10, Matthew Brett wrote:
> I am sorry, I am a bit lost. Should I expect replacing:
>
> > + device->flags.force_power_state = 1;
> > + acpi_bus_set_power(device->handle, state);
> > + device->flags.force_power_state = 0;
>
> with:
>
> > + if (state == ACPI_STATE_D0)
> > + acpi_bus_set_power(fan->handle, ACPI_STATE_D3);
> > + else if (state == ACPI_STATE_D3)
> > + acpi_bus_set_power(fan->handle, ACPI_STATE_D0);
> > + acpi_bus_set_power(fan->handle, state);
>
> in fan.c from 2.6.20-rc3 should solve the problem (replacing
> fan->handle with device->handle)? It does not seem to.
I think the "acpi_bus_set_power" call was added after
2.6.17. So if you remove it, I suspect your fan might work
like it used to.
I doubt that's the correct fix, though, because that call
was probably added for a reason. Konstantin can probably
speak to that.
If you feel like experimenting, you could print out what
state the BIOS tells you the fan is in (from the
acpi_bus_get_power() call), try setting it to either
ACPI_STATE_D0 or ACPI_STATE_D3, and see what the fan does.
next prev parent reply other threads:[~2007-01-08 5:08 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-28 17:14 PROBLEM: CPU fan shuts down on load of fan.ko in kernel 2.6.18 and later Matthew Brett
2006-12-28 21:03 ` Alexey Starikovskiy
2006-12-28 23:36 ` Matthew Brett
2007-01-03 11:40 ` Matthew Brett
2007-01-03 20:29 ` Bjorn Helgaas
2007-01-03 20:45 ` Alexey Starikovskiy
2007-01-07 20:10 ` Matthew Brett
2007-01-08 5:08 ` Bjorn Helgaas [this message]
2007-01-09 16:53 ` Karasyov, Konstantin A
2007-01-10 1:12 ` Matthew Brett
2007-01-10 3:18 ` Salatiel Filho
2007-01-11 13:37 ` Karasyov, Konstantin A
2007-01-13 12:23 ` Matthew Brett
[not found] <beb91d720701110549r346991beh95547e912f68d98f@mail.gmail.com>
2007-01-11 14:15 ` Karasyov, Konstantin A
2007-01-11 14:37 ` Salatiel Filho
2007-01-13 12:29 ` Matthew Brett
2007-01-13 13:12 ` Alexey Starikovskiy
2007-01-13 13:33 ` Matthew Brett
2007-01-13 15:51 ` Alexey Starikovskiy
2007-01-14 5:24 ` Bjorn Helgaas
2007-01-15 13:33 ` Karasyov, Konstantin A
2007-01-15 17:06 ` Bjorn Helgaas
2007-01-16 0:39 ` Matthew Brett
2007-01-17 2:49 ` Luming Yu
2007-01-17 9:02 ` Matthew Brett
2007-01-16 16:54 ` Bjorn Helgaas
2007-01-19 12:37 ` Karasyov, Konstantin A
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200701072208.07831.bjorn.helgaas@hp.com \
--to=bjorn.helgaas@hp.com \
--cc=konstantin.a.karasyov@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=matthew.brett@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox