From: Bjorn Helgaas <bjorn.helgaas@hp.com>
To: "Karasyov, Konstantin A" <konstantin.a.karasyov@intel.com>
Cc: Alexey Starikovskiy <alexey.y.starikovskiy@linux.intel.com>,
Matthew Brett <matthew.brett@gmail.com>,
Salatiel Filho <salatiel.filho@gmail.com>,
linux-acpi@vger.kernel.org
Subject: Re: PROBLEM: CPU fan shuts down on load of fan.ko in kernel 2.6.18 and later
Date: Tue, 16 Jan 2007 09:54:25 -0700 [thread overview]
Message-ID: <200701160954.26018.bjorn.helgaas@hp.com> (raw)
In-Reply-To: <E3C0BCA40296C347AF7142161DB9FC8298F74B@mssmsx411>
On Monday 15 January 2007 06:33, Karasyov, Konstantin A wrote:
> The fan device FAN1 defines object FN01 as its power resource. _STA
> method of FN01 always return 0x01, i.e. resource is on. So the fan
> driver is unable to turn the fan on, because it thinks that it is
> already in that state.
The code looks like this:
int acpi_bus_set_power(acpi_handle handle, int state)
{
...
if (!device->flags.force_power_state) {
if (device->power.state == ACPI_STATE_UNKNOWN)
acpi_bus_get_power(device->handle, &device->power.state)
if (state == device->power.state) {
return 0; /* already at desired state */
}
...
acpi_power_transition(device, state);
Why do we bother with the "acpi_bus_get_power" at all? The problem
Matthew is seeing wouldn't happen at all if we just deleted everything
in the force_power_state block.
Then we could execute _ON, _PS0, etc for a device that is already on.
Does that cause bad things to happen? I assume the fan probably works
as desired under Windows, so they probably do something like this.
Bjorn
next prev parent reply other threads:[~2007-01-16 16:54 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <beb91d720701110549r346991beh95547e912f68d98f@mail.gmail.com>
2007-01-11 14:15 ` PROBLEM: CPU fan shuts down on load of fan.ko in kernel 2.6.18 and later Karasyov, Konstantin A
2007-01-11 14:37 ` Salatiel Filho
2007-01-13 12:29 ` Matthew Brett
2007-01-13 13:12 ` Alexey Starikovskiy
2007-01-13 13:33 ` Matthew Brett
2007-01-13 15:51 ` Alexey Starikovskiy
2007-01-14 5:24 ` Bjorn Helgaas
2007-01-15 13:33 ` Karasyov, Konstantin A
2007-01-15 17:06 ` Bjorn Helgaas
2007-01-16 0:39 ` Matthew Brett
2007-01-17 2:49 ` Luming Yu
2007-01-17 9:02 ` Matthew Brett
2007-01-16 16:54 ` Bjorn Helgaas [this message]
2007-01-19 12:37 ` Karasyov, Konstantin A
2006-12-28 17:14 Matthew Brett
2006-12-28 21:03 ` Alexey Starikovskiy
2006-12-28 23:36 ` Matthew Brett
2007-01-03 11:40 ` Matthew Brett
2007-01-03 20:29 ` Bjorn Helgaas
2007-01-03 20:45 ` Alexey Starikovskiy
2007-01-07 20:10 ` Matthew Brett
2007-01-08 5:08 ` Bjorn Helgaas
2007-01-09 16:53 ` Karasyov, Konstantin A
2007-01-10 1:12 ` Matthew Brett
2007-01-10 3:18 ` Salatiel Filho
2007-01-11 13:37 ` Karasyov, Konstantin A
2007-01-13 12:23 ` Matthew Brett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200701160954.26018.bjorn.helgaas@hp.com \
--to=bjorn.helgaas@hp.com \
--cc=alexey.y.starikovskiy@linux.intel.com \
--cc=konstantin.a.karasyov@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=matthew.brett@gmail.com \
--cc=salatiel.filho@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox