Re: [patch 4/5] i386: turn on CONFIG_PNP in defconfig

[Len Brown <lenb@kernel.org>]

On Tuesday 16 January 2007 12:34, Bjorn Helgaas wrote:
> I'm trying to remove drivers/acpi/motherboard.c, which is mostly
> redundant with drivers/pnp/system.c.  So make sure that we include the
> PNP driver in the default config.  Most distros enable this already.
> 
> Turning on CONFIG_PNP also causes the following options to be enabled:
> 
>     CONFIG_PNPACPI
>     CONFIG_SERIAL_8250_PNP
> 
> CONFIG_SERIAL_8250_PNP causes legacy serial ports to be discovered
> twice, which is ugly but harmless:
> 
>     serial8250: ttyS0 at I/O 0x3f8 (irq = 4) is a 16550A
>     00:07: ttyS0 at I/O 0x3f8 (irq = 4) is a 16550A
> 
> Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
> 
> Index: mm-work13/arch/i386/defconfig
> ===================================================================
> --- mm-work13.orig/arch/i386/defconfig	2007-01-11 13:56:18.000000000 -0700
> +++ mm-work13/arch/i386/defconfig	2007-01-11 13:57:23.000000000 -0700
> @@ -466,7 +466,7 @@
>  #
>  # Plug and Play support
>  #
> -# CONFIG_PNP is not set
> +CONFIG_PNP=y
>  
>  #
>  # Block devices

shouldn't CONFIG_PNPACPI=y also appear in defconfig with this change?
If it doesn't, then somebody who runs make oldconfig will get prompted for it.

Also, do we need to be concerned about the case where
CONFIG_PNP=n
CONFIG_ACPI=y
This is the case that motherboard.c was intended to cover.

CONFIG_PNP depends on ACPI (or ISA)
But nothing mandates that somebody must select it.

what do you think?

-Len


-Len