From: Bjorn Helgaas <bjorn.helgaas@hp.com>
To: Len Brown <len.brown@intel.com>
Cc: linux-acpi@vger.kernel.org, Adam Belay <ambx1@neo.rr.com>,
Matthieu Castet <castet.matthieu@free.fr>,
Li Shaohua <shaohua.li@intel.com>
Subject: [patch 3/5] PNP: system.c whitespace cleanup
Date: Thu, 18 Jan 2007 16:43:46 -0700 [thread overview]
Message-ID: <200701181643.46746.bjorn.helgaas@hp.com> (raw)
In-Reply-To: <200701181636.45590.bjorn.helgaas@hp.com>
No functional change.
Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
Index: mm-work3/drivers/pnp/system.c
===================================================================
--- mm-work3.orig/drivers/pnp/system.c 2007-01-12 12:14:53.000000000 -0700
+++ mm-work3/drivers/pnp/system.c 2007-01-12 12:16:59.000000000 -0700
@@ -28,15 +28,15 @@
char *regionid;
regionid = kmalloc(16, GFP_KERNEL);
- if ( regionid == NULL )
+ if (regionid == NULL)
return;
snprintf(regionid, 16, "pnp %s", pnpid);
if (port)
res = request_region(start,end-start+1,regionid);
else
res = request_mem_region(start,end-start+1,regionid);
- if ( res == NULL )
- kfree( regionid );
+ if (res == NULL)
+ kfree(regionid);
else
res->flags &= ~IORESOURCE_BUSY;
/*
@@ -47,24 +47,18 @@
printk(KERN_INFO
"pnp: %s: %s range 0x%x-0x%x %s reserved\n",
pnpid, port ? "ioport" : "iomem", start, end,
- NULL != res ? "has been" : "could not be"
- );
-
- return;
+ NULL != res ? "has been" : "could not be");
}
-static void reserve_resources_of_dev( struct pnp_dev *dev )
+static void reserve_resources_of_dev(struct pnp_dev *dev)
{
int i;
- for (i=0;i<PNP_MAX_PORT;i++) {
+ for (i = 0; i < PNP_MAX_PORT; i++) {
if (!pnp_port_valid(dev, i))
- /* end of resources */
continue;
if (pnp_port_start(dev, i) == 0)
- /* disabled */
- /* Do nothing */
- continue;
+ continue; /* disabled */
if (pnp_port_start(dev, i) < 0x100)
/*
* Below 0x100 is only standard PC hardware
@@ -76,14 +70,10 @@
*/
continue;
if (pnp_port_end(dev, i) < pnp_port_start(dev, i))
- /* invalid endpoint */
- /* Do nothing */
- continue;
- reserve_range(
- dev->dev.bus_id,
- pnp_port_start(dev, i),
- pnp_port_end(dev, i), 1
- );
+ continue; /* invalid */
+
+ reserve_range(dev->dev.bus_id, pnp_port_start(dev, i),
+ pnp_port_end(dev, i), 1);
}
for (i = 0; i < PNP_MAX_MEM; i++) {
next prev parent reply other threads:[~2007-01-18 23:43 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-18 23:36 [0/5] remove ACPI motherboard driver, use PNP system driver instead (take 2) Bjorn Helgaas
2007-01-18 23:42 ` [patch 1/5] ACPI: move FADT resource reservations from motherboard driver to osl Bjorn Helgaas
2007-01-19 1:12 ` Shaohua Li
2007-01-19 19:46 ` Bjorn Helgaas
2007-01-22 1:27 ` Shaohua Li
2007-01-22 15:57 ` Bjorn Helgaas
2007-01-18 23:43 ` [patch 2/5] PNP: reserve system board iomem resources as well as ioport resources Bjorn Helgaas
2007-01-18 23:43 ` Bjorn Helgaas [this message]
2007-01-18 23:44 ` [patch 4/5] i386: turn on CONFIG_PNP in defconfig Bjorn Helgaas
2007-01-18 23:44 ` [patch 5/5] ACPI: remove motherboard driver (redundant with PNP system driver) Bjorn Helgaas
2007-01-19 15:37 ` [0/5] remove ACPI motherboard driver, use PNP system driver instead (take 2) emisca
2007-01-19 21:33 ` Bjorn Helgaas
2007-01-20 18:00 ` emisca
2007-01-22 16:25 ` Bjorn Helgaas
2007-01-23 9:07 ` emisca
2007-01-23 15:44 ` Bjorn Helgaas
2007-01-23 19:24 ` emisca
2007-01-29 22:53 ` Bjorn Helgaas
2007-01-29 23:00 ` Bjorn Helgaas
2007-01-29 23:19 ` Len Brown
2007-01-29 23:24 ` Bjorn Helgaas
2007-01-30 20:18 ` emisca
2007-02-03 22:16 ` emisca
2007-02-09 19:15 ` emisca
2007-02-16 3:57 ` Bjorn Helgaas
-- strict thread matches above, loose matches on Subject: below --
2007-01-16 17:28 [0/5] remove ACPI motherboard driver, use PNP system driver instead Bjorn Helgaas
2007-01-16 17:34 ` [patch 3/5] PNP: system.c whitespace cleanup Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200701181643.46746.bjorn.helgaas@hp.com \
--to=bjorn.helgaas@hp.com \
--cc=ambx1@neo.rr.com \
--cc=castet.matthieu@free.fr \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=shaohua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox