From: Bjorn Helgaas <bjorn.helgaas@hp.com>
To: Len Brown <len.brown@intel.com>
Cc: linux-acpi@vger.kernel.org, Adam Belay <ambx1@neo.rr.com>,
Matthieu Castet <castet.matthieu@free.fr>,
Li Shaohua <shaohua.li@intel.com>
Subject: [patch 5/5] ACPI: remove motherboard driver (redundant with PNP system driver)
Date: Thu, 18 Jan 2007 16:44:48 -0700 [thread overview]
Message-ID: <200701181644.48483.bjorn.helgaas@hp.com> (raw)
In-Reply-To: <200701181636.45590.bjorn.helgaas@hp.com>
The PNP system board driver (drivers/pnp/system.c) contains all the
same functionality, so we don't need the ACPI version.
Previously, a motherboard device would be claimed by *both* the ACPI and
PNP drivers, resulting in stuff like this in /proc/ioports:
1200-121f : motherboard <-- from drivers/acpi/motherboard.c
1200-121f : pnp 00:0d <-- from drivers/pnp/system.c
Make sure to enable CONFIG_PNP (and CONFIG_PNPACPI) to include the
PNP system board driver.
Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
Index: mm-work3/drivers/acpi/Makefile
===================================================================
--- mm-work3.orig/drivers/acpi/Makefile 2007-01-18 16:15:00.000000000 -0700
+++ mm-work3/drivers/acpi/Makefile 2007-01-18 16:15:29.000000000 -0700
@@ -37,7 +37,7 @@
obj-y += sleep/
obj-y += bus.o glue.o
-obj-y += scan.o motherboard.o
+obj-y += scan.o
obj-$(CONFIG_ACPI_AC) += ac.o
obj-$(CONFIG_ACPI_BATTERY) += battery.o
obj-$(CONFIG_ACPI_BUTTON) += button.o
Index: mm-work3/drivers/acpi/motherboard.c
===================================================================
--- mm-work3.orig/drivers/acpi/motherboard.c 2007-01-18 16:15:00.000000000 -0700
+++ /dev/null 1970-01-01 00:00:00.000000000 +0000
@@ -1,131 +0,0 @@
-/*
- * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or (at
- * your option) any later version.
- *
- * This program is distributed in the hope that it will be useful, but
- * WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- * General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License along
- * with this program; if not, write to the Free Software Foundation, Inc.,
- * 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA.
- *
- * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
- */
-
-/* Purpose: Prevent PCMCIA cards from using motherboard resources. */
-
-#include <linux/kernel.h>
-#include <linux/init.h>
-#include <linux/types.h>
-#include <linux/pci.h>
-#include <linux/ioport.h>
-#include <asm/io.h>
-
-#include <acpi/acpi_bus.h>
-#include <acpi/acpi_drivers.h>
-
-#define _COMPONENT ACPI_SYSTEM_COMPONENT
-ACPI_MODULE_NAME("acpi_motherboard")
-
-/* Dell use PNP0C01 instead of PNP0C02 */
-#define ACPI_MB_HID "PNP0C01,PNP0C02"
-/**
- * Doesn't care about legacy IO ports, only IO ports beyond 0x1000 are reserved
- * Doesn't care about the failure of 'request_region', since other may reserve
- * the io ports as well
- */
-#define IS_RESERVED_ADDR(base, len) \
- (((len) > 0) && ((base) > 0) && ((base) + (len) < IO_SPACE_LIMIT) \
- && ((base) + (len) > PCIBIOS_MIN_IO))
-/*
- * Clearing the flag (IORESOURCE_BUSY) allows drivers to use
- * the io ports if they really know they can use it, while
- * still preventing hotplug PCI devices from using it.
- */
-
-/*
- * When CONFIG_PNP is enabled, pnp/system.c binds to PNP0C01
- * and PNP0C02, redundant with acpi_reserve_io_ranges().
- * But acpi_reserve_io_ranges() is necessary for !CONFIG_PNP.
- */
-static acpi_status acpi_reserve_io_ranges(struct acpi_resource *res, void *data)
-{
- struct resource *requested_res = NULL;
-
-
- if (res->type == ACPI_RESOURCE_TYPE_IO) {
- struct acpi_resource_io *io_res = &res->data.io;
-
- if (io_res->minimum != io_res->maximum)
- return AE_OK;
- if (IS_RESERVED_ADDR
- (io_res->minimum, io_res->address_length)) {
- ACPI_DEBUG_PRINT((ACPI_DB_INFO,
- "Motherboard resources 0x%08x - 0x%08x\n",
- io_res->minimum,
- io_res->minimum +
- io_res->address_length));
- requested_res =
- request_region(io_res->minimum,
- io_res->address_length, "motherboard");
- }
- } else if (res->type == ACPI_RESOURCE_TYPE_FIXED_IO) {
- struct acpi_resource_fixed_io *fixed_io_res =
- &res->data.fixed_io;
-
- if (IS_RESERVED_ADDR
- (fixed_io_res->address, fixed_io_res->address_length)) {
- ACPI_DEBUG_PRINT((ACPI_DB_INFO,
- "Motherboard resources 0x%08x - 0x%08x\n",
- fixed_io_res->address,
- fixed_io_res->address +
- fixed_io_res->address_length));
- requested_res =
- request_region(fixed_io_res->address,
- fixed_io_res->address_length,
- "motherboard");
- }
- } else {
- /* Memory mapped IO? */
- }
-
- if (requested_res)
- requested_res->flags &= ~IORESOURCE_BUSY;
- return AE_OK;
-}
-
-static int acpi_motherboard_add(struct acpi_device *device)
-{
- if (!device)
- return -EINVAL;
- acpi_walk_resources(device->handle, METHOD_NAME__CRS,
- acpi_reserve_io_ranges, NULL);
-
- return 0;
-}
-
-static struct acpi_driver acpi_motherboard_driver = {
- .name = "motherboard",
- .class = "",
- .ids = ACPI_MB_HID,
- .ops = {
- .add = acpi_motherboard_add,
- },
-};
-
-static int __init acpi_motherboard_init(void)
-{
- acpi_bus_register_driver(&acpi_motherboard_driver);
- return 0;
-}
-
-/**
- * Reserve motherboard resources after PCI claim BARs,
- * but before PCI assign resources for uninitialized PCI devices
- */
-fs_initcall(acpi_motherboard_init);
next prev parent reply other threads:[~2007-01-18 23:44 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-18 23:36 [0/5] remove ACPI motherboard driver, use PNP system driver instead (take 2) Bjorn Helgaas
2007-01-18 23:42 ` [patch 1/5] ACPI: move FADT resource reservations from motherboard driver to osl Bjorn Helgaas
2007-01-19 1:12 ` Shaohua Li
2007-01-19 19:46 ` Bjorn Helgaas
2007-01-22 1:27 ` Shaohua Li
2007-01-22 15:57 ` Bjorn Helgaas
2007-01-18 23:43 ` [patch 2/5] PNP: reserve system board iomem resources as well as ioport resources Bjorn Helgaas
2007-01-18 23:43 ` [patch 3/5] PNP: system.c whitespace cleanup Bjorn Helgaas
2007-01-18 23:44 ` [patch 4/5] i386: turn on CONFIG_PNP in defconfig Bjorn Helgaas
2007-01-18 23:44 ` Bjorn Helgaas [this message]
2007-01-19 15:37 ` [0/5] remove ACPI motherboard driver, use PNP system driver instead (take 2) emisca
2007-01-19 21:33 ` Bjorn Helgaas
2007-01-20 18:00 ` emisca
2007-01-22 16:25 ` Bjorn Helgaas
2007-01-23 9:07 ` emisca
2007-01-23 15:44 ` Bjorn Helgaas
2007-01-23 19:24 ` emisca
2007-01-29 22:53 ` Bjorn Helgaas
2007-01-29 23:00 ` Bjorn Helgaas
2007-01-29 23:19 ` Len Brown
2007-01-29 23:24 ` Bjorn Helgaas
2007-01-30 20:18 ` emisca
2007-02-03 22:16 ` emisca
2007-02-09 19:15 ` emisca
2007-02-16 3:57 ` Bjorn Helgaas
-- strict thread matches above, loose matches on Subject: below --
2007-01-16 17:28 [0/5] remove ACPI motherboard driver, use PNP system driver instead Bjorn Helgaas
2007-01-16 17:35 ` [patch 5/5] ACPI: remove motherboard driver (redundant with PNP system driver) Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200701181644.48483.bjorn.helgaas@hp.com \
--to=bjorn.helgaas@hp.com \
--cc=ambx1@neo.rr.com \
--cc=castet.matthieu@free.fr \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=shaohua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox