Re: [patch 4/7] asus-laptop: add backlight support

[Len Brown <lenb@kernel.org>]

On Thursday 25 January 2007 06:54, Corentin CHARY wrote:
> Add backlight support using backlight class. We now change the brightness
> *and toggle the backlight !* via /sys/class/backlight/asus-laptop/ .
> 
> If the user switch the backlight using the keyboard, asus_hotk_notify looks for
> ATKD_LCD_OFF and ATKD_LCD_ON events, and store the right state into hotk->status
> and bd->props->power .
> 
> 
> Signed-off-by: Corentin Chary <corentincj@iksaif.net>
>  Kconfig       |    1
>  asus-laptop.c |  181 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++-

> diff -Naur a/drivers/misc/Kconfig b/drivers/misc/Kconfig
> --- a/drivers/misc/Kconfig	2007-01-21 15:29:27.000000000 +0100
> +++ b/drivers/misc/Kconfig	2007-01-21 15:34:26.000000000 +0100
> @@ -75,6 +75,7 @@
>          depends on ACPI
>  	depends on EXPERIMENTAL && !ASUS_ACPI
>  	select LEDS_CLASS
> +	select BACKLIGHT_CLASS_DEVICE

wups, my message about LED  CLASS was garbled.
What I should have written is:

Both of these select's should be "depends on"
select is generally considered evil and should be avoided if at all possible.

>          ---help---
>  	  This is the new Linux driver for Asus laptops. It may also support some
>  	  MEDION, JVC or VICTOR laptops. It makes all the extra buttons generate
>