Re: [patch 0/7] New misc/asus-laptop.c driver

[Corentin CHARY <corentincj@iksaif.net>]

>
> 1-7 applied to acpi-test
> I also ran scripts/Lindent over it to fix the whitespace.
> Then, after merging into acpi-test I also applied the patch below.
>
> Your choice if you want to make future updates with incremental patches
> on top of acpi-test or re-send the series.
incremental patches on top of acpi-test are fine :)

> Also, while I see that distros do set CONFIG_LEDS_CLASS,
> depending on it will make the driver vanish from menuconfig
> if somebody hasn't set it.  I don't know if this is a big deal or not.
> One possibility is to not depend on it in Kconfig, but via #ifdef's in the
> source. The other is to retreat to using select -- which I'm hopeful we can
> avoid. Or, maybe folks that don't get the driver via distro (who tend to
> enable everything) will not get stumped by this.
As the old asus_acpi doesn't work on new models, and still buggy, I think 
distros will enable asus-laptop (and LED/BACKLIGHT) by default ... Those that 
don't get the driver via distro will find it if they search (as the name 
asus-laptop is accepted, I will post a warning on acpi4asus.sf.net, to say 
that the driver have a new name, etc ...).
Thanks =) 

> thanks
> -Len

-- 
CHARY 'Iksaif' Corentin
http://xf.iksaif.net