Re: [PATCH 2/4] Remove /proc/acpi/sony interface and implement platform_device.

Mattia Dongili
2007-02-10T12:50:59Z

On Sat, Feb 10, 2007 at 02:47:19AM +0100, Alessandro Guido wrote:
> Thanks for doing this! I hope this will be merged soon in mainline :)
> I'm testing it on my VGN-FS215S and so far I haven't noticed any
> problem.
>
> Just a thing:
>
> brightness_default uses values starting from 1. In my opinion, it should
> be changed to use values starting from 0 to have some consistency or,
> better, have an entry itself in the backlight interface.

I don't think the latter is possible, at least not without patching the
backlight class framework but I don't know if this has ever been
discussed with backlight subsytem maintainers.

While I thought about the former suggestion too. It needs some work to
keep the generalized sysfs_{show,store} functions but it's definitely
worth implementing.

Thanks for the feedback :)
--
mattia
:wq!