[patch 05/13] ACPI: Make bay depend on dock

[patch 05/13] ACPI: Make bay depend on dock

[akpm]

From: Kristen Carlson Accardi <kristen.c.accardi@intel.com>

Since the bay driver depends on the dock driver for proper notification, make
this driver depend on the dock driver.

Signed-off-by: Kristen Carlson Accardi <kristen.c.accardi@intel.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 drivers/acpi/Kconfig |    1 +
 1 file changed, 1 insertion(+)

diff -puN drivers/acpi/Kconfig~acpi-make-bay-depend-on-dock drivers/acpi/Kconfig
--- a/drivers/acpi/Kconfig~acpi-make-bay-depend-on-dock
+++ a/drivers/acpi/Kconfig
@@ -151,6 +151,7 @@ config ACPI_FAN
 config ACPI_DOCK
 	tristate "Dock"
 	depends on EXPERIMENTAL
+	depends on ACPI_DOCK
 	help
 	  This driver adds support for ACPI controlled docking stations
 
_

Re: [patch 05/13] ACPI: Make bay depend on dock

[Len Brown]

Did you intend to make ACPI_BAY depend on ACPI_DOCK
instead of making ACPI_DOCK depend on ACPI_DOCK?

-Len

On Monday 05 February 2007 19:09, akpm@linux-foundation.org wrote:
> From: Kristen Carlson Accardi <kristen.c.accardi@intel.com>
> 
> Since the bay driver depends on the dock driver for proper notification, make
> this driver depend on the dock driver.
> 
> Signed-off-by: Kristen Carlson Accardi <kristen.c.accardi@intel.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
> 
>  drivers/acpi/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff -puN drivers/acpi/Kconfig~acpi-make-bay-depend-on-dock drivers/acpi/Kconfig
> --- a/drivers/acpi/Kconfig~acpi-make-bay-depend-on-dock
> +++ a/drivers/acpi/Kconfig
> @@ -151,6 +151,7 @@ config ACPI_FAN
>  config ACPI_DOCK
>  	tristate "Dock"
>  	depends on EXPERIMENTAL
> +	depends on ACPI_DOCK
>  	help
>  	  This driver adds support for ACPI controlled docking stations
>  
> _
> -
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

Re: [patch 05/13] ACPI: Make bay depend on dock

[Andrew Morton]

On Fri, 9 Feb 2007 00:50:10 -0500 Len Brown <lenb@kernel.org> wrote:

> Did you intend to make ACPI_BAY depend on ACPI_DOCK
> instead of making ACPI_DOCK depend on ACPI_DOCK?
> 
> -Len
> 
> On Monday 05 February 2007 19:09, akpm@linux-foundation.org wrote:
> > From: Kristen Carlson Accardi <kristen.c.accardi@intel.com>
> > 
> > Since the bay driver depends on the dock driver for proper notification, make
> > this driver depend on the dock driver.
> > 
> > Signed-off-by: Kristen Carlson Accardi <kristen.c.accardi@intel.com>
> > Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> > ---
> > 
> >  drivers/acpi/Kconfig |    1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff -puN drivers/acpi/Kconfig~acpi-make-bay-depend-on-dock drivers/acpi/Kconfig
> > --- a/drivers/acpi/Kconfig~acpi-make-bay-depend-on-dock
> > +++ a/drivers/acpi/Kconfig
> > @@ -151,6 +151,7 @@ config ACPI_FAN
> >  config ACPI_DOCK
> >  	tristate "Dock"
> >  	depends on EXPERIMENTAL
> > +	depends on ACPI_DOCK
> >  	help
> >  	  This driver adds support for ACPI controlled docking stations

I dunno what's going on with this one - it might have got mangled.  Please
drop.

Re: [patch 05/13] ACPI: Make bay depend on dock

[Kristen Carlson Accardi]

On Thu, 8 Feb 2007 22:01:52 -0800
Andrew Morton <akpm@linux-foundation.org> wrote:

> On Fri, 9 Feb 2007 00:50:10 -0500 Len Brown <lenb@kernel.org> wrote:
> 
> > Did you intend to make ACPI_BAY depend on ACPI_DOCK
> > instead of making ACPI_DOCK depend on ACPI_DOCK?
> > 
> > -Len
> > 
> > On Monday 05 February 2007 19:09, akpm@linux-foundation.org wrote:
> > > From: Kristen Carlson Accardi <kristen.c.accardi@intel.com>
> > > 
> > > Since the bay driver depends on the dock driver for proper notification, make
> > > this driver depend on the dock driver.
> > > 
> > > Signed-off-by: Kristen Carlson Accardi <kristen.c.accardi@intel.com>
> > > Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> > > ---
> > > 
> > >  drivers/acpi/Kconfig |    1 +
> > >  1 file changed, 1 insertion(+)
> > > 
> > > diff -puN drivers/acpi/Kconfig~acpi-make-bay-depend-on-dock drivers/acpi/Kconfig
> > > --- a/drivers/acpi/Kconfig~acpi-make-bay-depend-on-dock
> > > +++ a/drivers/acpi/Kconfig
> > > @@ -151,6 +151,7 @@ config ACPI_FAN
> > >  config ACPI_DOCK
> > >  	tristate "Dock"
> > >  	depends on EXPERIMENTAL
> > > +	depends on ACPI_DOCK
> > >  	help
> > >  	  This driver adds support for ACPI controlled docking stations
> 
> I dunno what's going on with this one - it might have got mangled.  Please
> drop.
> 

Eh - we do need this patch after all - here it is again - ACPI_BAY should
be dependent on ACPI_DOCK.


Subject: ACPI: Make bay depend on dock

Since the bay driver depends on the dock driver for proper notification,
make this driver depend on the dock driver. 

Signed-off-by: Kristen Carlson Accardi <kristen.c.accardi@intel.com>
---
 drivers/acpi/Kconfig |    1 +
 1 file changed, 1 insertion(+)

--- kristen-2.6.orig/drivers/acpi/Kconfig
+++ kristen-2.6/drivers/acpi/Kconfig
@@ -142,6 +142,7 @@ config ACPI_DOCK
 config ACPI_BAY
 	tristate "Removable Drive Bay"
 	depends on EXPERIMENTAL
+	depends on ACPI_DOCK
 	help
 	  This driver adds support for ACPI controlled removable drive
 	  bays such as the IBM ultrabay or the Dell Module Bay.