From: Len Brown <lenb@kernel.org>
To: Michael Hanselmann <linux-kernel@hansmi.ch>, linux-acpi@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
cappaberra@gmail.com
Subject: Re: Fix null pointer dereference in appledisplay driver
Date: Sat, 10 Feb 2007 00:39:20 -0500 [thread overview]
Message-ID: <200702100039.20956.lenb@kernel.org> (raw)
In-Reply-To: <20070210001823.GA3557@hansmi.ch>
Applied.
thanks,
-Len
On Friday 09 February 2007 19:18, Michael Hanselmann wrote:
> Commit 40b20c257a13c5a526ac540bc5e43d0fdf29792a by Len Brown introduced
> a null pointer dereference in the appledisplay driver. This patch fixes
> it.
>
> Signed-off-by: Michael Hanselmann <linux-kernel@hansmi.ch>
>
> ---
> I suggest adding this to 2.6.20.1 because this bug causes the kernel to
> panic on boot when the driver is compiled in.
>
> diff -Nrup --exclude-from linux-exclude-from linux-2.6.20.orig/drivers/usb/misc/appledisplay.c linux-2.6.20/drivers/usb/misc/appledisplay.c
> --- linux-2.6.20.orig/drivers/usb/misc/appledisplay.c 2007-02-09 22:35:56.000000000 +0100
> +++ linux-2.6.20/drivers/usb/misc/appledisplay.c 2007-02-10 01:00:28.000000000 +0100
> @@ -281,8 +281,8 @@ static int appledisplay_probe(struct usb
> /* Register backlight device */
> snprintf(bl_name, sizeof(bl_name), "appledisplay%d",
> atomic_inc_return(&count_displays) - 1);
> - pdata->bd = backlight_device_register(bl_name, NULL, NULL,
> - &appledisplay_bl_data);
> + pdata->bd = backlight_device_register(bl_name, NULL,
> + pdata, &appledisplay_bl_data);
> if (IS_ERR(pdata->bd)) {
> err("appledisplay: Backlight registration failed");
> goto error;
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
parent reply other threads:[~2007-02-10 5:40 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20070210001823.GA3557@hansmi.ch>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200702100039.20956.lenb@kernel.org \
--to=lenb@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=cappaberra@gmail.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@hansmi.ch \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox