public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Len Brown <lenb@kernel.org>
To: "Starikovskiy, Alexey" <alexey.y.starikovskiy@linux.intel.com>,
	"Pallipadi, Venkatesh" <venkatesh.pallipadi@intel.com>,
	robert.moore@intel.com
Cc: linux-acpi@vger.kernel.org
Subject: multiple MADT issue & acpi_get_table()
Date: Sun, 11 Feb 2007 00:57:05 -0500	[thread overview]
Message-ID: <200702110057.05952.lenb@kernel.org> (raw)

Alexey, Bob,

There are boxes with multiple MADT's in the RSDT,
and proof that Linux' current policy of choosing the 1st one
does not work around this BIOS bug properly.

http://bugzilla.kernel.org/show_bug.cgi?id=7465

Before the ACPICA table update, I had a patch in 7465
that made this situation verbose, and added a boot param so that
we could switch to using the last MADT and have a knob if
that didn't always work.

That patch is no good in 2.6.21 as ACPICA's acpi_get_table()
now owns finding the table instance.

Also, I see code in processor_core.c that is uses acpi_get_table()
to find the MADT -- so my patch in the bug report above probably
was incomplete anyway, as in some cases the table code would look at
one instance and the processor driver still looked a the 1st instance...

What do you suggest we do with acpi_map_table() to handle
the fact that when there are multiple MADT's, we probably always
want the last one?  Further, we need to issue a warning when this happens,
and we need a hook for a boot param in case it doesn't work for everybody.

Note that I've only seen this issue with the MADT.

thanks,
-Len

                 reply	other threads:[~2007-02-11  5:58 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200702110057.05952.lenb@kernel.org \
    --to=lenb@kernel.org \
    --cc=alexey.y.starikovskiy@linux.intel.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=robert.moore@intel.com \
    --cc=venkatesh.pallipadi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox