public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: John Keller <jpk@sgi.com>
To: linux-acpi@vger.kernel.org
Cc: ayoung@sgi.com, linux-ia64@vger.kernel.org,
	linux-kernel@vger.kernel.org, John Keller <jpk@sgi.com>
Subject: [PATCH 1/1] -  acpi_unload_table_id() always returns error
Date: Thu, 15 Feb 2007 14:08:30 -0600	[thread overview]
Message-ID: <20070215200830.1822.98901.sendpatchset@attica.americas.sgi.com> (raw)

acpi_unload_table_id() is always returning an error status.
Also, once the matching table is found, don't bother looking
for another match.


Signed-off-by: John Keller <jpk@sgi.com>
---


Index: release/drivers/acpi/tables/tbxface.c
===================================================================
--- release.orig/drivers/acpi/tables/tbxface.c	2007-02-13 08:20:42.000000000 -0600
+++ release/drivers/acpi/tables/tbxface.c	2007-02-15 14:04:07.855248010 -0600
@@ -338,9 +338,9 @@ acpi_status acpi_unload_table_id(acpi_ow
 	int i;
 	acpi_status status = AE_NOT_EXIST;
 
-	ACPI_FUNCTION_TRACE(acpi_unload_table);
+	ACPI_FUNCTION_TRACE(acpi_unload_table_id);
 
-	/* Find table from the requested type list */
+	/* Find table in the global table list */
 	for (i = 0; i < acpi_gbl_root_table_list.count; ++i) {
 		if (id != acpi_gbl_root_table_list.tables[i].owner_id) {
 			continue;
@@ -352,8 +352,9 @@ acpi_status acpi_unload_table_id(acpi_ow
 		* simply a position within the hierarchy
 		*/
 		acpi_tb_delete_namespace_by_owner(i);
-		acpi_tb_release_owner_id(i);
+		status = acpi_tb_release_owner_id(i);
 		acpi_tb_set_table_loaded_flag(i, FALSE);
+		break;
 	}
 	return_ACPI_STATUS(status);
 }

             reply	other threads:[~2007-02-15 20:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-15 20:08 John Keller [this message]
2007-02-16  4:29 ` [PATCH 1/1] - acpi_unload_table_id() always returns error Len Brown
2007-02-16 13:53   ` John Keller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070215200830.1822.98901.sendpatchset@attica.americas.sgi.com \
    --to=jpk@sgi.com \
    --cc=ayoung@sgi.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox