Re: [PATCH - 2.6.19 -0/2] Backport of psmouse suspend/shutdown cleanups

[Pavel Machek <pavel@ucw.cz>]

Hi!

I'm not input or stable maintainer, but...

> I like to ask for inclusion into stable series for these.
> 
> The original patch from Dmitry can be found here:
> http://bugzilla.kernel.org/show_bug.cgi?id=7689
> comment #64, #65.
> 
> The reason is:
>  - These patches fix a lot weird stuff on all recent
>    HP nc/nx series laptop models.

Well, I'd call that "work around hardware problems in broken HP
laptops". There's HP BIOS bugzilla somewhere, perhaps we should fix it
that way?

>  - The problem with the psmouse thing is, if you booted
>    a broken kernel, rebooting a fixed one will still result
>    in a broken system (things break (or get fixed) on shutdown
>    and survive the reboot).
>    Therefore the patch(es) should get into as much kernels
>    as possible to avoid further confusions on bug reports...

Yes, it is quite nasty problem, but:

1) Fix is non-trivial (>100 lines, which violates -stable rule IIRC)

2) Fix is very disconnected from the problem. "Deinitialize mouse so
that fans work after reboot". WTF?

3) AFAICT it is not a regression.

									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html