From: Pavel Machek <pavel@ucw.cz>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Thomas Renninger <trenn@suse.de>, Stable <Stable@kernel.org>,
linux-acpi <linux-acpi@vger.kernel.org>
Subject: Re: [PATCH - 2.6.19 -0/2] Backport of psmouse suspend/shutdown cleanups
Date: Wed, 21 Feb 2007 21:44:40 +0100 [thread overview]
Message-ID: <20070221204440.GK3732@elf.ucw.cz> (raw)
In-Reply-To: <d120d5000702211230s24b6ebdcja31ccb7359754931@mail.gmail.com>
Hi!
> On 2/21/07, Pavel Machek <pavel@ucw.cz> wrote:
> >
> >Yes, it is quite nasty problem, but:
> >
> >1) Fix is non-trivial (>100 lines, which violates -stable rule IIRC)
> >
>
> The fix itself is only 30 lines (counting empty lines and comments)
> which is not too bad.
Well, one of stable rules is
- It cannot be bigger than 100 lines, with context.
I guess it meets all the other criteria... I think this is for stable
team to decide.
> >2) Fix is very disconnected from the problem. "Deinitialize mouse so
> >that fans work after reboot". WTF?
>
> Can you imagine how I love this kind of bugs? ;)
Yep. But maybe we should force HP to fix their broken machines? They
even claim those machines are linux-certified (or suse-linux-certified
or something).... Shame on them.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2007-02-21 20:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-21 17:08 [PATCH - 2.6.19 -0/2] Backport of psmouse suspend/shutdown cleanups Thomas Renninger
2007-02-21 17:26 ` Dmitry Torokhov
2007-02-22 12:52 ` [PATCH - 2.6.19 -0/1] " Thomas Renninger
2007-02-22 15:02 ` Dmitry Torokhov
2007-02-26 14:21 ` Thomas Renninger
2007-02-26 14:34 ` Dmitry Torokhov
2007-02-28 16:46 ` Thomas Renninger
2007-02-21 19:52 ` [PATCH - 2.6.19 -0/2] " Pavel Machek
2007-02-21 20:22 ` Alexey Starikovskiy
2007-02-21 20:59 ` Henrique de Moraes Holschuh
2007-02-21 20:26 ` Rafael J. Wysocki
2007-02-21 20:30 ` Dmitry Torokhov
2007-02-21 20:44 ` Pavel Machek [this message]
2007-02-22 0:21 ` [stable] " Greg KH
2007-02-22 0:22 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070221204440.GK3732@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=Stable@kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-acpi@vger.kernel.org \
--cc=trenn@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox