From: Len Brown <lenb@kernel.org>
To: Alexey Starikovskiy <alexey.y.starikovskiy@linux.intel.com>
Cc: linux-acpi@vger.kernel.org
Subject: Re: EC init cleanup patches
Date: Fri, 23 Feb 2007 02:24:19 -0500 [thread overview]
Message-ID: <200702230224.19440.lenb@kernel.org> (raw)
In-Reply-To: <45DC9091.9050605@linux.intel.com>
On Wednesday 21 February 2007 13:33, Alexey Starikovskiy wrote:
> Hi,
> Here is the patch series to clean-up init of EC.
>
> Please test, comment.
> ACPI: EC: enable burst functionality in EC
seems to expose ec_burst_enable(), but nobody calls it --
so the patch has no functional change by itself, yes?
looks like some unrelated cleanups in that patch too.
anybody able to test this out on the samsung box
that had trouble with burst mode?
if we are going to cut over to enabling burst mode by default,
surely we should have a boot-param so the user can set it
to whatever works -- as well as a dmesg indicator so we
can tell what is going on -- like we do for ec_intr=, yes?
thanks,
-Len
ps. in the patch and mbox format, please include
a Signed-off-by: line in addition to the From: line --
i have to remember to add these manually when they're
not included in what you sent to me, and technically nobody should be adding
a signed-off-by line with somebody elses's name on it...
prev parent reply other threads:[~2007-02-23 7:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-21 18:33 EC init cleanup patches Alexey Starikovskiy
2007-02-23 7:24 ` Len Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200702230224.19440.lenb@kernel.org \
--to=lenb@kernel.org \
--cc=alexey.y.starikovskiy@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox