Re: Could the k8temp driver be interfering with ACPI?

Jean Delvare
2007-04-03T05:51:53Z

Hi Dave,

On Mon, 2 Apr 2007 15:22:09 -0400, Dave Jones wrote:
> On Mon, Apr 02, 2007 at 05:48:59PM +0200, Jean Delvare wrote:
> > + u8 val;
> > +#ifdef CONFIG_ACPI
> > + acpi_ut_acquire_mutex(ACPI_MTX_INTERPRETER);
> > +#endif
> > outb(reg, data->addr + ADDR_REG_OFFSET);
> > - return inb(data->addr + DATA_REG_OFFSET);
> > + val = inb(data->addr + DATA_REG_OFFSET);
> > +#ifdef CONFIG_ACPI
> > + acpi_ut_release_mutex(ACPI_MTX_INTERPRETER);
> > +#endif
> > + return val;
> > ... deletia, more of the same.
>
> it'd probably end up a lot cleaner to #define them to empty macros
> in the !ACPI case in acpi/acpi.h and just #include it unconditionally.

Sure, the implementation details can be refined later. I'm only trying
to see what can be done for now.

--
Jean Delvare